Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a race condition involving binary images being changed. #7459

Merged
merged 4 commits into from
Feb 4, 2021
Merged

Fix a race condition involving binary images being changed. #7459

merged 4 commits into from
Feb 4, 2021

Conversation

elenadoty
Copy link
Contributor

@elenadoty elenadoty commented Feb 4, 2021 •
edited
Loading

#no-changelog
@elenadoty elenadoty requested a review from samedson February 4, 2021 17:52
@google-cla google-cla bot added the cla: yes label Feb 4, 2021
@elenadoty elenadoty mentioned this pull request Feb 4, 2021
Closed
@chrisvasselli
Copy link

I am still seeing the crash even with this change, in my reproduction here: samedson/issues#1
@chrisvasselli
Copy link

Here's the new stack I'm seeing, and the line in the changed code that is still leading to the crash.

Screen Shot 2021-02-04 at 1 35 32 PM

Screen Shot 2021-02-04 at 1 35 42 PM
samedson
samedson approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@samedson samedson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a changelog and ship it!
@samedson
Copy link
Contributor

samedson commented Feb 4, 2021

Oh looks like @chrisvasselli is crashing on the added callback too
@chrisvasselli
Copy link

@samedson @elenadoty let me know if there's any more information about my system/setup you think might be useful. If you have any other fixes you'd like me to try, I'm happy to help.
@elenadoty
Copy link
Contributor Author

Hi @chrisvasselli ,
Thanks so much for helping us out on this. I've just pushed another change, would you mind trying that out?
@chrisvasselli
Copy link

@elenadoty that one seems to be working!
samedson
samedson approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@samedson samedson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doubly approved!
@elenadoty elenadoty changed the title Fix a race condition when binary images are removed. Feb 4, 2021
@elenadoty elenadoty merged commit d2469ba into master Feb 4, 2021
@elenadoty elenadoty deleted the race_fix branch February 4, 2021 21:41
@firebase firebase locked and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: crashlytics cla: yes
4 participants
@elenadoty @chrisvasselli @samedson @google-oss-bot