Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable app check platform logging #7948

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Re-enable app check platform logging #7948

merged 1 commit into from
Apr 23, 2021

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Apr 23, 2021

b/185793743
@google-cla google-cla bot added the cla: yes label Apr 23, 2021
ncooke3
ncooke3 commented Apr 23, 2021
View reviewed changes
FirebaseAppCheck/Sources/Core/APIService/FIRAppCheckAPIService.m
Comment on lines -114 to -116
NSString *versionHeader =
[NSString stringWithFormat:@"fire-app-check/%@", FIRFirebaseVersion()];
[request setValue:versionHeader forHTTPHeaderField:kUserAgentKey];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checking, this version header is intended to be removed, correct?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's correct.
@ncooke3 ncooke3 requested a review from maksymmalyhin April 23, 2021 14:10
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

maksymmalyhin
maksymmalyhin approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for the change!
@ncooke3 ncooke3 requested a review from ryanwilson April 23, 2021 15:01
@ncooke3
Copy link
Member Author

ncooke3 commented Apr 23, 2021

Performed a manual end-to-end test to confirm SDK properly interacts with server.
@ncooke3 ncooke3 merged commit 8c10bd5 into master Apr 23, 2021
@ncooke3 ncooke3 deleted the nc/ac-platform-logging branch April 23, 2021 16:44
@firebase firebase locked and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: appcheck cla: yes
4 participants
@ncooke3 @google-oss-bot @paulb777 @maksymmalyhin