Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions spm unit and build tests #8499

Merged
merged 7 commits into from
Aug 17, 2021
Merged

Conversation

jrcrespoh
Copy link
Contributor

@jrcrespoh jrcrespoh commented Aug 5, 2021

Tests ran successfully with watchos

pod lib lint fails on travis for watchos, but succeeds locally. Disabling test for now, pending GHA update to Xcode 12.5+

@jrcrespoh jrcrespoh requested review from ncooke3 and paulb777 August 5, 2021 15:49
@google-cla google-cla bot added the cla: yes label Aug 5, 2021
Package.swift Outdated Show resolved Hide resolved
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think we should add watchos to the each matrix in functions.yml Here's one such matrix.

@google-oss-bot
Copy link

google-oss-bot commented Aug 5, 2021

Coverage Report

Affected SDKs

No changes between base commit (c54fad2) and head commit (c7c29d7).

Test Logs

@paulb777
Copy link
Member

paulb777 commented Aug 5, 2021

Looks like pod lib lint does not work for watch OS. https://travis-ci.org/github/firebase/firebase-ios-sdk/jobs/774699071

@google-cla google-cla bot added cla: no and removed cla: yes labels Aug 16, 2021
@paulb777 paulb777 added cla: yes and removed cla: no labels Aug 16, 2021
@firebase firebase deleted a comment from google-cla bot Aug 16, 2021
@google-cla

This comment has been minimized.

@google-cla google-cla bot added cla: no and removed cla: yes labels Aug 16, 2021
@paulb777 paulb777 added cla: yes and removed cla: no labels Aug 16, 2021
@google-cla
Copy link

google-cla bot commented Aug 16, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Aug 16, 2021
@paulb777 paulb777 added cla: yes and removed cla: no labels Aug 16, 2021
@google-cla
Copy link

google-cla bot commented Aug 16, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot removed the cla: yes label Aug 16, 2021
@google-cla google-cla bot added the cla: no label Aug 16, 2021
@google-cla
Copy link

google-cla bot commented Aug 16, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@paulb777 paulb777 added cla: yes and removed cla: no labels Aug 16, 2021
@paulb777 paulb777 marked this pull request as ready for review August 16, 2021 22:00
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM 👍 . Added one comment about SwiftPM excludes as I havent seen that issue before

Package.swift Outdated Show resolved Hide resolved
@google-cla
Copy link

google-cla bot commented Aug 16, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Aug 16, 2021
@paulb777 paulb777 added cla: yes and removed cla: no labels Aug 16, 2021
@jrcrespoh
Copy link
Contributor Author

What should be done about incremental code coverage reports? I imagine these should not surface on tests?

@paulb777
Copy link
Member

@granluo is working on the incremental coverage reporting separately.

@jrcrespoh This PR should be good to resolve and merge here.

@jrcrespoh jrcrespoh merged commit 52b3560 into master Aug 17, 2021
@jrcrespoh jrcrespoh deleted the jc-functions-watchos branch August 17, 2021 00:08
@firebase firebase locked and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.