[Dynamic links] Shortlink is not handled in 8.8.0

[eiskalt]

[REQUIRED] Step 1: Describe your environment

• Xcode version: 13.0
• Firebase SDK version: 8.8.0
• Installation method: CocoaPods
• Firebase Component: DynamicLinks

[REQUIRED] Step 2: Describe the problem

Steps to reproduce:

Try to use DynamicLinks.dynamicLinks().handleUniversalLink(url) on a shortlink for a Firebase generated DynamicLink.

Links of the format https://*.page.link/test do not match the new regex that was implemented in this commit 85864c6

Full links of the format https://*.page.link/?link=https://google.com/test do work correctly.

They are working correctly in 8.7.0.

[google-oss-bot]

I found a few problems with this issue:

• I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
• This issue does not seem to follow the issue template. Make sure you provide all the required information.

[eldhosembabu]

taking a look...will keep you posted

[eldhosembabu]

I was not able to reproduce this issue. Do you mind providing a sample url that you are using for testing?

I've tried reproducing this issue on a sample app and it was working as expected.

I've added a unit test to check this specifically in PR : #8793 and the unit tests are green.

Also we already have a unit test in place to check the link format whether it will match the regex here : https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseDynamicLinks/Tests/Unit/FIRDynamicLinksTest.m#L1109

If this issue is still reproducible on your end, would be great if you can provide us a sample app (use the Dynamic Links Quick Start App : https://github.com/firebase/quickstart-ios/tree/master/dynamiclinks) along with a video on reproducing the issue as it will help us to reproduce the issue on our end and to come up with a fix if required.

[eiskalt]

I did a little more investigation and it appears to be failing when the link includes a - (which I didn't include in my example as I assumed it was just failing for all) for example https://*.page.link/test-test.

I have tested the regex using the above example and it is failing when the- is included.

[paulb777]

The test in #8793 still passes for me if I change line 1378 to NSString *urlString = @"https://foo.page.link/?link=https://google.com/test-test";

[paulb777]

Could the issue be related to a non-ASCII -(dash)?

[eldhosembabu]

@paulb777 in the above comment, we tried with the long link...we need to try with short link ie. https://foo.page.link/test-test which going to be failing since the regex is not expecting '-' and/or '_' in the short FDL identifier. This happens when user manually creates the short link with the above characters. I'll do a quick fix and update the PR here.

[eldhosembabu]

Added support for '_' and '-' in PR : #8793

Also added unit test cases for the same.

[eiskalt]

Thanks for looking into it 😄

[eldhosembabu]

The PR is merged and the fix should be available in 8.9.0.

Closing this bug for now.