Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppCheck support for watchOS #9191

Closed
Semty opened this issue Jan 10, 2022 · 7 comments · Fixed by #9226
Closed

AppCheck support for watchOS #9191

Semty opened this issue Jan 10, 2022 · 7 comments · Fixed by #9226

Comments

@Semty
Copy link

Semty commented Jan 10, 2022

Feature proposal

  • Firebase Component: AppCheck

We've implemented support for AppCheck in our app ecosystem (iOS, Android, Web) and thinking about enforcing App Check verification.

The main obstacle is that we have watchOS as well and it seems that AppCheck doesn't support it (well, of course, DeviceCheck and AppAttest just not available on watchOS).

What is the expected behaviour in this situation? Should we just abandon the idea of using AppCheck in a foreseeable future or there is some workaround we could do?

@google-oss-bot
Copy link

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@paulb777
Copy link
Member

@Semty Thanks for the request. AppCheck should be community supported where possible for watchOS.

We just merged a PR fix today - #9187 that fixes a Firebase podspec issue for watchOS that will be available with the next release - 8.11.0. In the meantime - a CocoaPods workaround might be changing the Podfile from Firebase/AppCheck to FirebaseAppCheck

@paulb777
Copy link
Member

I'll close since there is a staged fix and workaround, but please comment if you have another issue and we can reopen.

@Semty
Copy link
Author

Semty commented Jan 18, 2022

@paulb777 hey! it seems that the desired effect is seen only with using Cocoapods, but with SPM I get this after adding AppCheck for watchOS target:
DeviceCheck is not available when building for watchOS.

@Semty
Copy link
Author

Semty commented Jan 19, 2022

@paulb777 hello! Thank you for the quick response!

Of course, DeviceCheck is not available for watchOS, but the truth is that I don't use it in a watchOS target, I get this error just by adding FirebaseAppCheck package to the watchOS target

@paulb777
Copy link
Member

@Semty Thanks for clarifying! I can reproduce and it looks like a problem in the Package.swift specification. I'll reopen and see if I can come up with a fix.

@paulb777 paulb777 reopened this Jan 19, 2022
@paulb777 paulb777 self-assigned this Jan 19, 2022
@paulb777 paulb777 added this to the 8.12.0 - M111 milestone Jan 19, 2022
@firebase firebase locked and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.