Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore 8.13.0 - Warnings in Firestore/core/src/local/local_serializer.cc #9430

Closed
Sunrise17 opened this issue Mar 8, 2022 · 4 comments · Fixed by #9433
Closed

Firestore 8.13.0 - Warnings in Firestore/core/src/local/local_serializer.cc #9430

Sunrise17 opened this issue Mar 8, 2022 · 4 comments · Fixed by #9433
Assignees
@dconeybe
Labels
api: firestore
Milestone
8.14.0 - M113

Comments

@Sunrise17
Copy link

[REQUIRED] Step 1: Describe your environment

  • Xcode version: 13.2.1
  • Firebase SDK version: 8.13.0
  • Installation method: CocoaPods (select one)
  • Firebase Component: Firestore
  • Target platform(s): iOS

[REQUIRED] Step 2: Describe the problem

After updating pods to new version (8.13.0) in my iOS Project, i have received following warnings as seen in attached screenshot of following file.
File path: Firestore/core/src/local/local_serializer.cc

Firestore:core:src:local:local_serializer
@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.
@ncooke3 ncooke3 mentioned this issue Mar 8, 2022
Merged
@dconeybe dconeybe self-assigned this Mar 8, 2022
@dconeybe
Copy link
Contributor

dconeybe commented Mar 8, 2022

Looks like we are implicitly converting from size_t to uint32_t, which can be a lossy conversion. I'll fix this.
@dconeybe dconeybe mentioned this issue Mar 9, 2022
Merged
@dconeybe
Copy link
Contributor

dconeybe commented Mar 9, 2022

The fix has been merged and will be included in the next release.
@morganchen12 morganchen12 added this to the 8.14.0 - M113 milestone Mar 9, 2022
@dconeybe
Copy link
Contributor

The fix has been released in 8.14.0
@firebase firebase locked and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: firestore
5 participants
@morganchen12 @Sunrise17 @google-oss-bot @ncooke3 @dconeybe