Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update async/await code to be available for iOS 13, etc. #9483

Closed
paulb777 opened this issue Mar 20, 2022 · 6 comments
Closed

Update async/await code to be available for iOS 13, etc. #9483

paulb777 opened this issue Mar 20, 2022 · 6 comments
Assignees
Milestone

Comments

@paulb777
Copy link
Member

Now that it is supported for iOS 13 instead of 15 starting with Xcode 13.2.1

@paulb777 paulb777 added this to the Firebase 9 milestone Mar 20, 2022
@ryanwilson
Copy link
Member

This will bump our min Xcode version to Xcode 13.2.1 right?

@paulb777
Copy link
Member Author

Right.

Seems worth it for the next major release to get the broader async/await support and Xcode 13.2.1+ usage is already 63%

@ryanwilson
Copy link
Member

ryanwilson commented Mar 21, 2022

I wonder if we could use #if swift(>=5.5.2)` to check for it and set it to 13, otherwise set it to 15. May be a bit messy but could buy us a bit more time and we don't have that many instances of it.

The one caveat is 13.2.0 specifically would break I think, but if we were thinking of removing support anyways it's not a huge deal.

@paulb777
Copy link
Member Author

Maybe, but is the complexity/maintainability worth it? I think most people will update their Xcode versions quicker than Firebase major versions.

@ryanwilson
Copy link
Member

Testing this out now as there are only 7 non-test instances of these declarations.

@ryanwilson
Copy link
Member

This is fixed in #9540

@firebase firebase locked and limited conversation to collaborators May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants