Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make getDataWithCompletionBlock snapshot nullable #9655

Merged
merged 6 commits into from
Apr 20, 2022
Merged

Make getDataWithCompletionBlock snapshot nullable #9655

merged 6 commits into from
Apr 20, 2022

Conversation

jmwski
Copy link
Contributor

@jmwski jmwski commented Apr 14, 2022 •
edited by ryanwilson
Loading

Fixes #9614
@google-oss-bot
Copy link

Size Report 1

Affected Products

  • FirebaseDatabase

    TypeBase (58a5c8a)Merge (4749d4a)Diff
    CocoaPods?1.36 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Zvh2mLGJ4J.html
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    Overall coverage changed from ? (58a5c8a) to 56.89% (4749d4a) by ?.

    102 individual files with coverage change

    FilenameBase (58a5c8a)Merge (4749d4a)Diff
    APLevelDB.mm?61.30%?
    FAckUserWrite.m?83.33%?
    FArraySortedDictionary.m?97.49%?
    FAtomicNumber.m?100.00%?
    fbase64.c?32.00%?
    FCacheNode.m?100.00%?
    FCachePolicy.m?17.14%?
    FCancelEvent.m?0.00%?
    FChange.m?88.24%?
    FChildChangeAccumulator.m?62.32%?
    FChildEventRegistration.m?0.00%?
    FChildrenNode.m?90.40%?
    FClock.m?100.00%?
    FCompoundHash.m?97.70%?
    FCompoundWrite.m?91.12%?
    FConnection.m?26.09%?
    FDataEvent.m?29.41%?
    FEmptyNode.m?100.00%?
    FEventEmitter.m?0.00%?
    FEventGenerator.m?95.37%?
    FEventRaiser.m?30.00%?
    FImmutableSortedDictionary.m?31.03%?
    FImmutableSortedSet.m?53.01%?
    FImmutableTree.m?85.02%?
    FIndex.m?91.67%?
    FIndexedFilter.m?95.65%?
    FIndexedNode.m?97.06%?
    FIRDatabase.m?14.93%?
    FIRDatabaseComponent.m?19.23%?
    FIRDatabaseConfig.m?59.62%?
    FIRDatabaseConnectionContextProvider.m?96.67%?
    FIRDatabaseQuery.m?3.86%?
    FIRDatabaseReference.m?6.41%?
    FIRDataSnapshot.m?89.71%?
    FIRMutableData.m?75.51%?
    FIRRetryHelper.m?82.14%?
    FIRServerValue.m?0.00%?
    FIRTransactionResult.m?0.00%?
    FKeepSyncedEventRegistration.m?0.00%?
    FKeyIndex.m?60.56%?
    FLeafNode.m?86.98%?
    FLevelDBStorageEngine.m?72.66%?
    FLimitedFilter.m?96.79%?
    FListenComplete.m?0.00%?
    FLLRBEmptyNode.m?75.00%?
    FLLRBValueNode.m?84.83%?
    FMaxNode.m?60.61%?
    FMerge.m?87.18%?
    FNamedNode.m?62.32%?
    FNextPushId.m?62.00%?
    FOperationSource.m?89.29%?
    FOverwrite.m?81.48%?
    FPath.m?93.86%?
    FPathIndex.m?88.75%?
    FPendingPut.m?0.00%?
    FPersistenceManager.m?54.55%?
    FPersistentConnection.m?20.95%?
    FPriorityIndex.m?87.84%?
    FPruneForest.m?93.08%?
    FQueryParams.m?95.86%?
    FQuerySpec.m?86.36%?
    FRangedFilter.m?93.67%?
    FRangeMerge.m?94.06%?
    FRepo.m?13.42%?
    FRepoInfo.m?73.00%?
    FRepoManager.m?29.17%?
    FServerValues.m?50.85%?
    FSnapshotHolder.m?100.00%?
    FSnapshotUtilities.m?60.45%?
    FSparseSnapshotTree.m?97.20%?
    FSRWebSocket.m?40.82%?
    FStringUtilities.m?79.41%?
    FSyncPoint.m?86.99%?
    FSyncTree.m?70.73%?
    FTrackedQuery.m?75.38%?
    FTrackedQueryManager.m?90.00%?
    FTransformedEnumerator.m?100.00%?
    FTree.m?6.04%?
    FTreeNode.m?100.00%?
    FTreeSortedDictionary.m?95.79%?
    FTreeSortedDictionaryEnumerator.m?100.00%?
    FTupleNodePath.m?0.00%?
    FTupleObjectNode.m?0.00%?
    FTuplePathValue.m?100.00%?
    FTupleRemovedQueriesEvents.m?100.00%?
    FTupleSetIdPath.m?0.00%?
    FTupleStringNode.m?0.00%?
    FTupleTransaction.m?0.00%?
    FTupleUserCallback.m?0.00%?
    FUtilities.m?74.01%?
    FValidation.m?25.58%?
    FValueEventRegistration.m?0.00%?
    FValueIndex.m?48.53%?
    FView.m?78.98%?
    FViewCache.m?100.00%?
    FViewProcessor.m?90.86%?
    FViewProcessorResult.m?100.00%?
    FWebSocketConnection.m?41.91%?
    FWriteRecord.m?45.65%?
    FWriteTree.m?73.67%?
    FWriteTreeRef.m?100.00%?
    NSData+SRB64Additions.m?81.82%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/R4INpzhaKj.html
@morganchen12 morganchen12 requested a review from ryanwilson April 14, 2022 22:13
@paulb777 paulb777 added this to the Firebase 9 milestone Apr 15, 2022
ryanwilson
ryanwilson approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the one CHANGELOG fix
FirebaseDatabase/CHANGELOG.md Outdated Show resolved Hide resolved
@ryanwilson ryanwilson enabled auto-merge (squash) April 20, 2022 00:27
@ryanwilson ryanwilson merged commit 8a9e385 into master Apr 20, 2022
@ryanwilson ryanwilson deleted the jw/issue/9614 branch April 20, 2022 00:27
@firebase firebase locked and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: database public-api-change
5 participants
@jmwski @google-oss-bot @ryanwilson @morganchen12 @paulb777