Add unchanged names to existence filter and watchFilters spec test runner #10862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconeybe
requested changes
Feb 24, 2023
There was a problem hiding this comment.
We need to fix the proto passing and memory management issue in this PR. I haven't reviewed all of this PR but wanted to send the feedback now so you can have a chance to review prior to our meeting in an hour. The logic you want to achieve in this PR is a bit more difficult than it had appeared on the surface!
milaGGL
commented
Mar 8, 2023
milaGGL
commented
Mar 8, 2023
milaGGL
commented
Mar 8, 2023
dconeybe
requested changes
Mar 16, 2023
dconeybe
requested changes
Mar 17, 2023
dconeybe
requested changes
Mar 17, 2023
dconeybe
approved these changes
Mar 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#no-changelog
Ported from Web SDK: firebase/firebase-js-sdk#6839
unchangedNamesandbitsoptional in protobloom_filtertoExistenceFilterclassunchangedNamestoExistenceFilterdoWatchFilterto acceptNSDictionaryinstead ofNSArraydoWatchFilter(watchFilter: SpecWatchFilter), the specWatchFilter input type changed from an array to object:doWatchFilterchange above(no bloom filter proto json values are included)