Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SessionToken persistence implementation #13684

Merged
merged 13 commits into from
Sep 25, 2024
Merged

SessionToken persistence implementation #13684

merged 13 commits into from
Sep 25, 2024

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Sep 20, 2024 •
edited
Loading

Internal change to Firestore.

Prepare persistence of session token. This will be used in future work to support database name resuse.

This was reverted to delay release: #13719
@tom-andersen tom-andersen requested a review from wu-hui September 24, 2024 14:47
@tom-andersen tom-andersen marked this pull request as ready for review September 24, 2024 14:47
wu-hui
wu-hui approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits, please do fix them before merging.

LGTM in the meantime.
Firestore/core/src/local/globals_cache.h Outdated Show resolved Hide resolved
Firestore/core/src/local/leveldb_key.h Outdated Show resolved Hide resolved
Firestore/core/src/local/leveldb_key.h Outdated Show resolved Hide resolved
@wu-hui wu-hui assigned tom-andersen and unassigned wu-hui Sep 24, 2024
@tom-andersen tom-andersen merged commit 2893101 into main Sep 25, 2024
34 checks passed
@tom-andersen tom-andersen deleted the tomandersen/sessionTokenPersistence branch September 25, 2024 13:09
paulb777
paulb777 reviewed Sep 25, 2024
View reviewed changes
Firestore/CHANGELOG.md
@@ -1,5 +1,6 @@
# Unreleased
- [changed] Improve efficiency of memory persistence when processing a large number of writes. (#13572)
- [changed] Prepare Firestore cache to support session token.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change missed yesterday's code freeze. Please move to unreleased.
tom-andersen added a commit that referenced this pull request Sep 25, 2024
@tom-andersen
Revert "SessionToken persistence implementation (#13684)"
ce29aaf 
This reverts commit 2893101.
@tom-andersen tom-andersen mentioned this pull request Sep 25, 2024
Merged
paulb777 pushed a commit that referenced this pull request Sep 25, 2024
@tom-andersen
Revert "SessionToken persistence implementation (#13684)" (#13719)
fb09f93
tom-andersen added a commit that referenced this pull request Oct 3, 2024
@tom-andersen
Reapply "SessionToken persistence implementation (#13684)" (#13719)
8601f41 
This reverts commit fb09f93.
@tom-andersen tom-andersen mentioned this pull request Oct 3, 2024
Merged
tom-andersen added a commit that referenced this pull request Oct 3, 2024
@tom-andersen
Reapply "SessionToken persistence implementation (#13684)" (#13719) (#…
8738b84 
…13794)
@firebase firebase locked and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: firestore
4 participants
@tom-andersen @paulb777 @wu-hui @google-oss-bot