avoid calling [UIApplication sharedApplication] in app extensions #1503
Conversation
| #ifdef COCOAPODS | ||
| #import <GoogleUtilities/GULAppEnvironmentUtil.h> | ||
| #else | ||
| #import "third_party/firebase/ios/Source/GoogleUtilities/Environment/third_party/GULAppEnvironmentUtil.h" |
There was a problem hiding this comment.
Don't publish internal paths - let copybara make the translation.
Firebase/Messaging/FIRMessaging.m
Outdated
| @@ -611,7 +611,8 @@ - (BOOL)shouldBeConnectedAutomatically { | |||
| // We require a token from Instance ID | |||
| NSString *token = self.defaultFcmToken; | |||
| // Only on foreground connections | |||
| UIApplicationState applicationState = [UIApplication sharedApplication].applicationState; | |||
| UIApplication *application = FIRMessagingUIApplication(); | |||
| UIApplicationState applicationState = application.applicationState; | |||
There was a problem hiding this comment.
This may return UIApplicationStateActive for extensions regardless of the host application state. Is that the correct behavior?
There was a problem hiding this comment.
We haven't finalized the official support for extensions so any function is called in extensions is not guarantee to be working. This CL just to ensure compilation works.
There was a problem hiding this comment.
If developer wants to establish a MCS connection in app extensions, it should probably work so the application state is for extension app.
There was a problem hiding this comment.
Actually no, the application object would be nil, so there's no way to check the application state in extensions. Basically we should return no for this case.
I'm also adding nil check for all the cases here.
| @@ -98,7 +99,8 @@ - (void)swizzleMethodsIfPossible { | |||
| return; | |||
| } | |||
|
|
|||
| NSObject<UIApplicationDelegate> *appDelegate = [[UIApplication sharedApplication] delegate]; | |||
| UIApplication *application = FIRMessagingUIApplication(); | |||
| NSObject<UIApplicationDelegate> *appDelegate = [application delegate]; | |||
There was a problem hiding this comment.
Should there be a nil-check here before swizzling?
check the UIApplication is nil before swizzling
This should make FCM compilable inside app extensions as requested by #1490