ensure NSUserDefaults is synchronized after setting values #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlotteliang
changed the title
paulb777
approved these changes
Aug 7, 2018
morganchen12
approved these changes
Aug 7, 2018
There was a problem hiding this comment.
This change is harmless, but I'm not convinced it'll resolve the flakiness. Normally calling synchronize after writing a value is unnecessary (see the "Storing user settings in NSUserDefaults" section here).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensure the aync persist is complete before continue. This should fix the flakiness of integration tests.