-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a boolean value on whether to use direct channel callback for all ios versions #1875
Conversation
…ack for all iOS versions
Please fix travis issue:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the new flag be both set via an API and an Info.plist setting?
|
||
#import <OCMock/OCMock.h> | ||
|
||
#ifdef COCOAPODS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove ifdef. It should be created by copybara
One more change needed. I noticed 'GoogleUtilities/Environment' is missing from the podspec dependencies in https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseMessaging.podspec. It's working because of transitive dependencies, but it should be added to make the dependency explicit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on travis green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one optional nit.
Add a new boolean value that control whether to use direct channel callback for all iOS versions. This partially resolves the issue #1409.
We are separating the callback between apns and direct channel. Right now for iOS 10 and above, direct channel message delivered at FIRMessagingDelegate, while for iOS 9 and below, they were delivered at UIApplicationDelegate. To not break existing behavior, if user likes to receive direct channel callback using FIRMessagingDelegate instead of UIApplicationDelegate for all ios versions, they can now set the boolean value useMessagingDelegateForDirectChannel to true.