Add support for validating FDL links from custom domains. #1962
Conversation
Allow for custo domains to be whitelisted by the info.plist file.
There was a problem hiding this comment.
Please address the two failing unit tests on travis:
https://travis-ci.org/firebase/firebase-ios-sdk/jobs/442453702
Looks like an extra call to [FIRApp configure]?
Done.
FIRDynamicLinksTest
testInvalidCustomDomainNames, failed: caught "com.firebase.core", "Default app has already been configured."
/Users/travis/build/firebase/firebase-ios-sdk/Example/DynamicLinks/Tests/FIRDynamicLinksTest.m:1054
[FIRApp configure];
NSArray<NSString *> *urlStrings = @[
testValidCustomDomainNames, failed: caught "com.firebase.core", "Default app has already been configured."
/Users/travis/build/firebase/firebase-ios-sdk/Example/DynamicLinks/Tests/FIRDynamicLinksTest.m:1027
[FIRApp configure];
NSArray<NSString *> *urlStrings = @[
Executed 129 tests, with 2 failures (2 unexpected) in 1.578 (1.952) seconds
2018-10-17 00:56:17.268 xcodebuild[8624:17626] [MT] IDETestOperationsObserverDebug: 157.318 elapsed -- Testing started completed.
2018-10-17 00:56:17.268 xcodebuild[8624:17626] [MT] IDETestOperationsObserverDebug: 0.000 sec, +0.000 sec -- start
2018-10-17 00:56:17.268 xcodebuild[8624:17626] [MT] IDETestOperationsObserverDebug: 157.318 sec, +157.318 sec -- end
Failing tests:
-[FIRDynamicLinksTest testInvalidCustomDomainNames]
-[FIRDynamicLinksTest testValidCustomDomainNames]
** TEST FAILED **
| <string>https://mydomain.com</string> | ||
| <string>https://mydomain2.com</string> | ||
| <string>https://google.com</string> | ||
| <string>https://google.com</string> |
| <string>https://mydomain.com</string> | ||
| <string>https://mydomain2.com</string> | ||
| <string>https://google.com</string> | ||
| <string>https://google.com</string> |
This feature is not yet available for public consumption.