-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Links shouldn't read from defaultOptions
#2112
Comments
Any update for this issue? Right now, we're stuck. Any help will be appreciated. Thank you. |
I'll try to take a look today to see how invasive the change will be - hopefully it's easy to pipe through. |
This was fixed and will be out in the next release. |
Wow, thank you for the fast fixed! May I know when 5.14 release come out? |
You're very welcome 😄 by policy, we don't commit to dates for upcoming releases, but I will say that we are hoping to get 5.14.0 out with this issue fixed next week. |
firebase-ios-sdk/Firebase/DynamicLinks/FDLURLComponents/FIRDynamicLinkComponentsKeyProvider.m
Line 29 in c724f9d
Currently Dynamic Links reads from the defaultOptions plist to get the API key - this should be fetched from
FIRApp
incase developers manually set options.This was discovered by @forsen in #230.
The text was updated successfully, but these errors were encountered: