Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of Game Center sign in #2127

Merged
merged 5 commits into from
Dec 1, 2018
Merged

Add support of Game Center sign in #2127

merged 5 commits into from
Dec 1, 2018

Conversation

renkelvin
Copy link
Contributor

No description provided.

@paulb777 paulb777 requested a review from ryanwilson November 28, 2018 19:33
ryanwilson
ryanwilson reviewed Nov 28, 2018
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just small nits, otherwise LGTM.
Example/Auth/Tests/FIRSignInWithGameCenterTests.m Outdated Show resolved Hide resolved
Firebase/Auth/Source/FIRAuthErrorUtils.m Outdated Show resolved Hide resolved
Firebase/Auth/Source/NSData+FIRBase64.h Outdated Show resolved Hide resolved
Firebase/Auth/Source/Public/FIRAuthErrors.h Show resolved Hide resolved
Firebase/Auth/Source/Public/FIRGameCenterAuthProvider.h Outdated Show resolved Hide resolved
Firebase/Auth/Source/RPCs/FIRSignInWithGameCenterRequest.h Outdated Show resolved Hide resolved
Firebase/Auth/Source/RPCs/FIRSignInWithGameCenterRequest.h Outdated Show resolved Hide resolved
Firebase/Auth/Source/RPCs/FIRSignInWithGameCenterRequest.m Show resolved Hide resolved
Firebase/Auth/Source/RPCs/FIRSignInWithGameCenterResponse.h Outdated Show resolved Hide resolved
Firebase/Auth/Source/RPCs/FIRSignInWithGameCenterResponse.m Outdated Show resolved Hide resolved
@renkelvin renkelvin merged commit 6632255 into master Dec 1, 2018
@renkelvin renkelvin deleted the game-center branch December 1, 2018 01:30
bstpierr added a commit that referenced this pull request Dec 6, 2018
@bstpierr
Merge branch 'master' into bs-appauthcleanup
c4ae7f4 
* master: (26 commits)
  Functions Interop (#2113)
  Add a travis cron job for CocoaPod symbol collision testing (#2154)
  Save schema version on downgrade, add test to verify (#2153)
  Silence Storage Unit Test `nil` warning. (#2150)
  Update versions for Release 5.14.0 (#2145)
  gRPC: fix cases where gRPC call could be finished twice (#2146)
  Fix Swizzler test warnings (#2144)
  Update Auth CHANGELOG.md (#2128)
  Make fuzz tests optional until they pass (#2143)
  Add support of Game Center sign in (#2127)
  Add test for deprecated FDLURLComponents init API. (#2133)
  fix a typo in integration test (#2131)
  Make fuzzing less verbose to avoid exceeding Travis log limit (#2126)
  Move to `domainURIPrefix` for FIRDynamicLinkComponents (#2119)
  Carthage instructions for new gRPCCertificates.bundle location (#2132)
  Fix pod lib lint GoogleUtilities.podspec --use-libraries regression (#2130)
  Avoid using default FIROptions directly. (#2124)
  Changelog entry for LRU GC (#2122)
  Revert "Add Firebase Source to Header Search Path" (#2123)
  Custom fdl domain (#2121)
  ...
@renkelvin renkelvin restored the game-center branch December 17, 2018 22:58
@Thaina Thaina mentioned this pull request May 5, 2022
Open
@renkelvin renkelvin deleted the game-center branch February 5, 2019 22:50
@firebase firebase locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: auth cla: yes
5 participants
@renkelvin @paulb777 @ryanwilson @Yue-Wang-Google @googlebot