Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate Microsoft and Yahoo Auth Provider ID #2517

Merged
merged 4 commits into from
Mar 12, 2019
Merged

deprecate Microsoft and Yahoo Auth Provider ID #2517

merged 4 commits into from
Mar 12, 2019

Conversation

Yue-Wang-Google
Copy link
Contributor

No description provided.

ryanwilson
ryanwilson previously requested changes Mar 11, 2019
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change then LGTM.
Firebase/Auth/Source/Public/FIROAuthProvider.h Outdated Show resolved Hide resolved
@renkelvin renkelvin added this to the M45 milestone Mar 12, 2019
ryanwilson
ryanwilson reviewed Mar 12, 2019
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the Travis whitespace issue, then LGTM. Thanks
@Yue-Wang-Google Yue-Wang-Google merged commit b67bc10 into master Mar 12, 2019
@Yue-Wang-Google Yue-Wang-Google deleted the Yue-Wang-Google-patch-3 branch March 12, 2019 21:40
@firebase firebase locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes
4 participants
@Yue-Wang-Google @renkelvin @ryanwilson @googlebot