FIRInstanceIDCheckinService: make sure tasks are not submitted to an invalidated NSURLSession #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…invalidated NSURLSession
| @@ -65,6 +65,7 @@ typedef NS_ENUM(NSInteger, FIRInstanceIDMessageCode) { | |||
| kFIRInstanceIDMessageCodeService004 = 7004, | |||
| kFIRInstanceIDMessageCodeService005 = 7005, | |||
| kFIRInstanceIDMessageCodeService006 = 7006, | |||
| kFIRInstanceIDMessageCodeService007 = 7007, | |||
There was a problem hiding this comment.
we start giving the message code a meaning instead of a repeat number.
So you can do sth like kFIRIntsanceIDInvalidNetworkSession.
ryanwilson
reviewed
Mar 13, 2019
charlotteliang
approved these changes
Mar 14, 2019
|
@ryanwilson @chliangGoogle Should this PR be cherry-picked to M45? |
|
Added to M45. @chliangGoogle Please close any relevant issues and update the release notes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick fix for the issue #2534.
Looks like there is a race condition involving
FIRInstanceID/FIRInstanceIDTokenManager/FIRInstanceIDAuthService/FIRInstanceIDCheckinService. I was not able to find a core reason why the issue may happen so far.The PR just fixes the particular consequence of the race condition to mitigate the impact on users while we are looking for a better solution.