Cocoapods 1.7.0 multiproject support (b/128794527) #2751
Conversation
maksymmalyhin
commented
Apr 8, 2019
maksymmalyhin
commented
- header imports fixes - use modular headers where required
- test project to validate different Cocoapods versions
- Travis configuration
…ilation fails on cocoa pods integration
Conflicts: Firebase/Core/Public/FIRConfiguration.h
.travis.yml
Outdated
| - stage: cocoapods_compatibility_check | ||
| name: Validate all Cocoapods configurations | ||
| script: | ||
| # TODO: ./scripts/if_changed.sh to ./scripts/if_cron.sh once testing finished |
There was a problem hiding this comment.
I would like to test it together with other tests before merging. I'll change it once it's tested.
| @@ -0,0 +1,17 @@ | |||
| // | |||
| // AppDelegate.h | |||
There was a problem hiding this comment.
update licenses and include in style.sh
| @@ -0,0 +1,102 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| # Copyright 2018 Google | |||
.travis.yml
Outdated
| name: Validate all Cocoapods configurations | ||
| script: | ||
| # TODO: ./scripts/if_changed.sh to ./scripts/if_cron.sh once testing finished | ||
| - travis_retry ./scripts/if_changed.sh ./CocoapodsIntegrationTest/scripts/build_all_environments.sh |
There was a problem hiding this comment.
I would like to run it one more time from the PR. I'll change it to if_cron once the build passes.
| } | ||
|
|
||
|
|
||
| - (void)applicationWillResignActive:(UIApplication *)application { |
There was a problem hiding this comment.
Nit: if these unused methods are going to stay empty, I think we just just remove them from the file.
|
This build illustrates the checks to be run for cron builds https://travis-ci.org/firebase/firebase-ios-sdk/builds/517562628 |
| @@ -1,4 +1,6 @@ | |||
| # Unreleased | |||
| - `GULAppDelegateSwizzler`: support of remote notification methods. (#2698) | |||
There was a problem hiding this comment.
Is this file intended to be in this PR?
There was a problem hiding this comment.
Well, probably, the changelog changes should have been better be in a different PR, but I would prefer to merge the PR to avoid waiting for another build to finish.
|
@paulb777 Thanks! |
