-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack + Typescript messaging.getToken() #2712
Comments
I think this is the issue - https://bugs.chromium.org/p/chromium/issues/detail?id=802280 I tested your link in Chrome 80, and there is no error. Can you please update your Chrome and retry? |
After update to chrome 80 it working now. Thank you. |
Why is this closed? The messaging library is currently broken in all but the very newest versions of Chrome and therefore can't be used in any serious projects. Sounds like an open issue to me ;) I'm sure you will fix it, thanks for your hard work by the way 👍 |
This is a legitimate issue. The SDK should be backward compatible. Thanks @geminixandroid @mitschabaude for bringing this up. I am working on a fix. |
Fix should be picked up in the next release. From the release history, the culprit exists for 7.7.0<=version<=7.13.1. If you hit the issue, please consider using a newer version. |
@zwu52 I am experiencing the bug also with 7.13.1, is it really fixed in that release? |
Hi @vandres, my previous comment was not accurate. Thanks for catching. I have updated above. The fix will be picked up in the next release (scheduled 2020-04-02). Please refer to the release note for updates. |
@zwu52 thanks for the heads up |
This RN is meant for the release scheduled on 2020-04-02. The fix will addresses the issues in #2712
* Create FCM's CHANGELOG.md with a release note. This RN is meant for the release scheduled on 2020-04-02. The fix will addresses the issues in #2712 * Update CHANGELOG.md Improves wording on Eric's feedback. Thansk Eric * Update CHANGELOG.md Fix a type Co-authored-by: Kai Wu <kaiwu@google.com>
Context: the tests were switched off a couple of years ago due to flakiness. It has not been maintained since then. During the time, Some Selenium API methods used were deprecated and removed; the Firebase projects used are no longer managed or owned by the FCM team. Consequently, the test became unfunctional. In the effort of providing safety for the upcoming FCM releases, this PR is created to fix, deflake, refactor and improve the old tests. This PR did the following: - Enabled comprehensive IT for chrome (ver.80). Now we are covering send&foreground recevie for FCM messages (messages with {notification} payload, {data} payload and {notification, data} payload), delete/update token, use default/customized ServiceWorker. - Defalaked test. The IT is now reasonably stable without retry. Previously we are retrying 1 or 3 times. - Optimized test. Previously we create a webDriver for each test, which is slow and annoying. Because a window is created and brought to focus and killed frequently, it makes working on other tasks and testing nearly impossible (Probably using a headless browser would work but I haven't found a satisfying solution to have the app in the state of foreground and background which is a requirement for FCM functions). With the way the tests are organized, the IT only spin up a new web driver when necessary. Some data on performance: (old) 'test-send' take 74 seconds (only measured 'test-send' because the other test suites were not functional at the time); (now) 'test-send', 'test-deleteToken', 'test-updateToken', 'test-useDefaultServiceWorker', 'test-useValidManifest' takes in total 33s (10 run average). - General refactoring. Including refactors on expect blocks, createWebDriver, use const for constants usage, etc. The code should be much easier to understand and maintain. Future work: - Enable test on firefox once I get the notification permission working. - Run the IC against some milestone chrome/firefox version (if it makes sense) to ensure backward compatibility. We should try to avoid #2712 . :)
[REQUIRED] Describe your environment
[REQUIRED] Describe the problem
firebase.messaging().getToken() throws error
at index.esm.js:790
Steps to reproduce:
look console
https://test.geminixandroid.com
Relevant Code:
package.json
The text was updated successfully, but these errors were encountered: