Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sendSignInLinkToEmail sends incorrect link on iOS after updating to Firebase 9 #5541

Closed
t0mstah opened this issue Sep 24, 2021 · 1 comment · Fixed by #5542
Closed

sendSignInLinkToEmail sends incorrect link on iOS after updating to Firebase 9 #5541

t0mstah opened this issue Sep 24, 2021 · 1 comment · Fixed by #5542

Comments

@t0mstah
Copy link

t0mstah commented Sep 24, 2021

[REQUIRED] Describe your environment

  • Operating System version: N/A
  • Browser version: N/A
  • Firebase SDK version: 9.0.2
  • Firebase Product: auth

[REQUIRED] Describe the problem

After updating from Firebase 8 to Firebase 9, dynamic link on iOS is broken:

Previous link sent in email: https://eureka.page.link/?link=https://eurekasurveys.com/email...
New link sent in email: https://eurekasurveys.com/email...

Missing the eurkea.page.link prefix being sent by sendSignInLinkToEmail.

Steps to reproduce:

Send Signin Link to iOS device on Firebase 9.

Relevant Code:

    await firebase.auth().sendSignInLinkToEmail(email, {
        handleCodeInApp: true,
        iOS: {
            bundleId: '[REDACTED]',
        },
        url: 'https://www.eurekasurveys.com/surveys/'
    })
@sam-gc
Copy link
Contributor

sam-gc commented Sep 24, 2021

Thanks for filing this issue! This is indeed a bug, I've been able to reproduce it. I'm working on a fix, stay tuned!

@sam-gc sam-gc added the bug label Sep 24, 2021
@firebase firebase locked and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants