Incorrect auth typing in 9.8.0: Cannot find name 'PhoneOrOauthTokenResponse

[jnizet]

• Operating System version: macOS
• Browser version: NA
• Firebase SDK version: 9.8.0
• Firebase Product: auth

[REQUIRED] Describe the problem

The TypeScript typings of version 9.8.0 are incorrect. When compiling against them, I get the error

Error: node_modules/@firebase/auth/dist/auth-public.d.ts:3137:22 - error TS2304: Cannot find name 'PhoneOrOauthTokenResponse'.

3137     _tokenResponse?: PhoneOrOauthTokenResponse;
                          ~~~~~~~~~~~~~~~~~~~~~~~~~

Error: node_modules/@firebase/auth/dist/auth-public.d.ts:3429:11 - error TS2304: Cannot find name 'UserInternal'.

3429     user: UserInternal;
               ~~~~~~~~~~~~

And indeed, if we look into the referenced file, we find, at line 2440:

/* Excluded from this release type: PhoneOrOauthTokenResponse */

So the type PhoneOrOauthTokenResponse has been commented out, but it's used at line 3137:

declare interface TaggedWithTokenResponse {
    _tokenResponse?: PhoneOrOauthTokenResponse;
}

The same issue exists with UserInternal. At line3468, we have

/* Excluded from this release type: UserInternal */

but at line 3429, we have

declare interface UserCredentialInternal extends UserCredential, TaggedWithTokenResponse {
    user: UserInternal;
}

[hsubox76]

Something about #6151 caused api-extractor to try to export TaggedWithTokenResponse and UserCredentialInternal as public types when it hadn't previously. Not sure why this change would have triggered this, but I am making a PR to tag these explicitly as internal.

[vandres]

Will there be a quick patch, as it makes that release unusable?

[hsubox76]

Merged, will try to get a release out today.

[hsubox76]

Released in 9.8.1

[jnizet]

Thanks @hsubox76