Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I was checking typings of GtagConfigParams, and looks like there is a typo in:
firebase-js-sdk/packages/analytics/src/public-types.ts
Line 73 in 11d37ed
My first thought was, that this param is really named allow_google_signals?, however checked with docs and correct name is just allow_google_signals: https://developers.google.com/analytics/devguides/collection/gtagjs/display-features
allow_google_signals?
allow_google_signals
Another attribute for comparison looks ok:
Line 78 in 11d37ed
The text was updated successfully, but these errors were encountered:
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
Merged a PR for this
I was checking typings of GtagConfigParams, and looks like there is a typo in:
firebase-js-sdk/packages/analytics/src/public-types.ts
Line 73 in 11d37ed
My first thought was, that this param is really named
allow_google_signals?
, however checked with docs and correct name is justallow_google_signals
: https://developers.google.com/analytics/devguides/collection/gtagjs/display-featuresAnother attribute for comparison looks ok:
firebase-js-sdk/packages/analytics/src/public-types.ts
Line 78 in 11d37ed
The text was updated successfully, but these errors were encountered: