Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade @firebase/polyfill core-js #6503

Closed
mhDuke opened this issue Aug 4, 2022 · 6 comments · Fixed by #6543
Closed

upgrade @firebase/polyfill core-js #6503

mhDuke opened this issue Aug 4, 2022 · 6 comments · Fixed by #6543

Comments

@mhDuke
Copy link

mhDuke commented Aug 4, 2022

npm WARN deprecated core-js@3.6.5:
core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues.

Please, upgrade your dependencies to >=3.23.3 of core-js.

@google-oss-bot
Copy link
Contributor

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@g-30
Copy link

g-30 commented Aug 12, 2022

second this

@dorji-tshering
Copy link

Same issue here. Just installed firebase right now. I hope it will be resolved soon!

@MarwanSdeek
Copy link

same issue while installing the latest firebase@9.9.2.

@playtinum
Copy link

Bump

@hsubox76
Copy link
Contributor

So the good news is that core-js code isn't used in the code for any Firebase SDK products installed through NPM. It was included in @firebase/polyfill package which is currently only bundled into the compat CDN builds (where Firebase is included using script tags, and applying only to urls that end with -compat.js). We forgot to remove it from the dependencies in package.json (which is why it's installing during yarn/npm install) but the code isn't imported into any Firebase code.

NPM users and users of the v9 CDN scripts shouldn't need to worry. I'll remove @firebase/polyfill from the dependencies and you should stop getting that warning after the next release.

As of v9 we've stopped updating @firebase/polyfill and expect users to provide their own so I'll also remove the polyfill import from the compat CDNs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
8 participants