Explicitly set createdAt and lastLoginAt when cloning UserImpl #7066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedys
requested review from
lisajian,
prameshj,
renkelvin and
sam-gc
as code owners
🦋 Changeset detectedLatest commit: 9fdbdc6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mdedys
changed the title
prameshj
reviewed
Mar 1, 2023
prameshj
approved these changes
Mar 1, 2023
|
cc @sam-gc |
sam-gc
approved these changes
Mar 6, 2023
Merged
renkelvin
pushed a commit
that referenced
this pull request
Mar 21, 2023
* Explicilty set createdAt and lastLoginAt when cloning UserImpl * Use metadata._copy instead of manually setting metadata * Fix test case for user_imply _clone function * Create fluffy-seas-behave.md --------- Co-authored-by: prameshj <pavithrar@google.com>
renkelvin
pushed a commit
that referenced
this pull request
Mar 21, 2023
* Explicilty set createdAt and lastLoginAt when cloning UserImpl * Use metadata._copy instead of manually setting metadata * Fix test case for user_imply _clone function * Create fluffy-seas-behave.md --------- Co-authored-by: prameshj <pavithrar@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Problem being addressed:
When calling
updateCurrentUserthe code clones the UserImpl class but incorrectly clones the UserMetadata resulting inundefinedvalues.Line of code calling
_clone:firebase-js-sdk/packages/auth/src/core/auth/auth_impl.ts
Line 343 in bea604e
_clonefunction: https://github.com/firebase/firebase-js-sdk/blob/master/packages/auth/src/core/user/user_impl.ts#L142.The spread operator only passes keys on the UserImpl class and will not pass the Metadata properties belonging to
UserMetadata. This causes https://github.com/firebase/firebase-js-sdk/blob/master/packages/auth/src/core/user/user_impl.ts#L142 to fail.This is missed in the test because the metadata properties are never set:
firebase-js-sdk/packages/auth/src/core/user/user_impl.test.ts
Line 257 in b6c231a