-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to execute 'subscribe' on 'PushManager': Subscription failed - no active Service Worker #7784
Comments
Hi. |
This is using Flutter for web? The problem stated above is for push notifications via web browsers (using Js service workers). Did you try registering the service worker before requesting the token?
Did it solve the issue? |
where i need to add this above code in 'firebase-messaging-sw.js' or in lib folder |
In your library. Not in firebase-messaging-sw.js as this code is referencing/loading firebase-messaging-sw.js |
sorry, i still don't get it. can you tell me exactly where I need to add this
Sorry, i still don't get this. can you tell me exactly where i need to add this. |
Load it on your web page wherever you want to detect push notifications. For me it's loadad on every web page |
I have this error too in my NextJS application. Except my error persists and does not disappear on page refresh. The |
I have the same error, I followed documentation. And got this error when first worker is registered even when I add explicit worker registration. After refresh, I got error:
This is happened every time. |
I can create reproduction since I have basic code, I'm not even able to setup the messaging. |
Please share the code that reproduces your issue. |
Here is repro https://github.com/jcubic/firebase-sw-bug The service worker use importScript and the reset of the code use |
@jcubic if you use it with flutter you must use the latest supported version: |
@rickypid I don't use Flutter. |
My issue was related to Brave see: Google push notifications - DOMException: Registration failed - push service error. The first error happened because of a bug in Firebase that require to register the Service Worker yourself. Adding |
Sorry if I'm misunderstanding, but what is the bug in Firebase that you're referring to? It seems like from that link the problem is with Brave prohibiting notifications by default? Can you clarify what the Firebase bug is? |
@hsubox76 the main issue is that firebase suppose to register the service worker and use it. But it do not do this. It can't find the service worker unless you register it yourself. I call it a bug since in documentation there are no information about this hidden |
I think I identified a possible cause. FYI I don't think it's related to providing the registration or not - for me, your repro project actually fails on the first try most of the time, but then succeeds on every subsequent time (until I unregister the service worker in devtools and try again). It has the same behavior even if I provide the registration explicitly. I think it's a race condition. When I think we have to have Trying to think of if this will have any unintended consequences. I guess if it never activates, for whatever reason, it could cause the app to hang. |
Thanks for explanation, but I will not use notification with Firebase, the API is silly. It was simple now is really hard to use. It looks like Google don't care about DX and make it harder and harder to use this API. Basically, I don't care anymore that this doesn't work out of the box. |
Ok, well, thanks for your helpful repro project at least! If we manage to fix this bug I'm sure your efforts will be appreciated by any other users having this issue who are still using the SDK. |
Operating System
Windows 10
Browser Version
Chrome Version 96.0.4664.55
Firebase SDK Version
9.5.0
Firebase SDK Product:
Messaging
Describe your project's tooling
JS (via webpack deployment)
Generic HTML (and/or Typo3 CMS) with PHP technology
Describe the problem
This is actually a follow-on and solution to these two closed bug reports, as no official solution was provided:
#6013
#5797
Cited information:
" Sometimes calling messaging getToken returns the error: Failed to execute 'subscribe' on 'PushManager': Subscription failed - no active Service Worker. It seems to only occur on the first page load, when the user refreshes the notifications work and there's no error anymore. "...
Please note I run the same code on two websites, swapping out the various keys required for each Firebase setup.
The websites are exact copies of each other, running as entirely separate websites.
On website there is no problem at all. On the second website I see the getToken error mentioned above.
After further testing I can confirm this issue is related to some issue picking up the "default" service worker if not explicitly referenced and registered.
getToken(messaging, { vapidKey: 'XXXXXX' }
As stated we don't have to send the serviceWorkerRegistration if it's using the default name. BUT sometimes (and there is no indication of why or when), the above request will return the error message without it. Perhaps it occurs when this initialisation code runs before the service worker has loaded in to memory? Or not.
Regardless, the solution (and I would like confirmation that this is the defacto solution) is to register and include the service worker before making this request, even if you are using the default service worker filename "firebase-messaging-sw.js".
const swRegistration = await navigator.serviceWorker.register('/firebase-messaging-sw.js');
getToken(messaging, { vapidKey: 'XXXXXX', serviceWorkerRegistration: swRegistration })
If this is the solution, perhaps it would be better to make the serviceWorkerRegistration field mandatory rather than optional?
Steps and code to reproduce issue
Steps to reproduce:
Add firebase-messaging-sw.js to root of domain
Call firebase initializeApp
Call firebase getMessaging
Ask and approve browser notification permission
Add firebase onMessage listener
Call firebaseawait getToken(messaging, { vapidKey: <VAPID_KEY> })
Error sometimes appears with Failed to execute 'subscribe' on 'PushManager': Subscription failed - no active Service Worker
Relevant Code:
firebase-messaging-sw.js is at the root of project and firebase gets initialised right away:
The text was updated successfully, but these errors were encountered: