Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firebase/functions does not respect a custom path the in the customDomain parameter #8440

Closed
segevfiner opened this issue Aug 19, 2024 · 1 comment · Fixed by #8441
Closed

Comments

@segevfiner
Copy link
Contributor

Operating System

macOS 14.6.1

Browser Version

Chrome/127.0.6533.120

Firebase SDK Version

10.12.5

Firebase SDK Product:

Functions

Describe your project's tooling

Vue app with Vite

Describe the problem

Trying to set a custom domain using getFunction(app, 'https://example.org/functions') doesn't work due to the SDK not handling it correctly.

I already have a fix. I'm only opening this issue since it is required to do so to open a PR.

Steps and code to reproduce issue

Just do getFunction(app, 'https://example.org/functions'), the functions get's send to just the origin without the path.

@segevfiner segevfiner added new A new issue that hasn't be categoirzed as question, bug or feature request question labels Aug 19, 2024
@google-oss-bot
Copy link
Contributor

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@jbalidiong jbalidiong added api: functions needs-attention and removed needs-triage new A new issue that hasn't be categoirzed as question, bug or feature request labels Aug 19, 2024
@firebase firebase locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.