Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nodejs builds #5400

Merged
merged 4 commits into from
Aug 30, 2021
Merged

Fix nodejs builds #5400

merged 4 commits into from
Aug 30, 2021

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Aug 28, 2021 •
edited
Loading

Fixes angular/angularfire#2903

  • Fix cjs build of app-compat, so it works with mjs import in Nodejs/bundlers
  • Expose firestore/lite in Nodejs by defining the exports field
@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2021

🦋 Changeset detected

Latest commit: 7db1aac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@firebase/analytics-compat Patch
@firebase/app-check-compat Patch
@firebase/app-compat Patch
@firebase/functions-compat Patch
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR
@Feiyang1
Copy link
Member Author

@jamesdaniels fyi
@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Warning: This PR modifies files in the following packages but they have not been included in the changeset file:

    • @firebase/analytics-compat
    • @firebase/app-check-compat
    • @firebase/app-compat
    • @firebase/functions-compat

    Make sure this was intentional.
@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (509c18f) and head commit (3588e13).
@Feiyang1 Feiyang1 merged commit cd15df0 into master Aug 30, 2021
@Feiyang1 Feiyang1 deleted the fei-mjs branch August 30, 2021 17:37
@google-oss-bot google-oss-bot mentioned this pull request Aug 30, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants
@Feiyang1 @google-oss-bot @hsubox76