-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for repoGet request #6273
Fix for repoGet request #6273
Conversation
🦋 Changeset detectedLatest commit: 7e09d4b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (925,925 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after some docs are added. Ignore the note about testing refactor (or take it as a suggestion for a followup PR).
We'll want to generate a changeset here: docs: https://github.com/firebase/firebase-js-sdk/blob/master/CONTRIBUTING.md#adding-changeset-to-pr, example: https://github.com/firebase/firebase-js-sdk/pull/4408/files. |
yarn.lock
Outdated
@@ -17099,7 +17099,7 @@ uuid@^3.0.0, uuid@^3.3.2, uuid@^3.3.3: | |||
resolved "https://registry.npmjs.org/uuid/-/uuid-3.4.0.tgz#b23e4358afa8a202fe7a100af1f5f883f02007ee" | |||
integrity sha512-HjSDRw6gZE5JMggctHBcjVak08+KEVhSIiDzFnT9S9aegmp85S/bReBVTb4QTFaRNptJ9kuYaNhnbNEOkbKb/A== | |||
|
|||
uuid@^8.3.2: | |||
uuid@^8.0.0, uuid@^8.3.2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional? Seems like we shouldn't need to pull in an older version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I assumed yarn would've resolved to the existing one installed in the repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is still here?
Latest commit w new tests LGTM. @jsdt could you have a look for code-owner approval? |
@@ -56,7 +56,8 @@ | |||
"@firebase/app": "0.7.25", | |||
"rollup": "2.72.1", | |||
"rollup-plugin-typescript2": "0.31.2", | |||
"typescript": "4.2.2" | |||
"typescript": "4.2.2", | |||
"uuid": "^8.3.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid bringing in an extra dep here? I see in app-check we just implemented a function ourselves, is this good enough?
export function uuidv4(): string { |
If it is, maybe we can extract it into @firebase/util
and share it between app-check and database (maybe in a later PR, just have a duplicate implementation in this one?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let me just reimplement it here and add a TODO
Fix issue where the wrong cache was being updated by get. First noticed here