Fix proactive refresh logic, add some tests #6544

sam-gc · 2022-08-18T17:57:26Z

We noticed the logic in the proactive refresh code was not quite correct (it wasn't turning on for newly-signed-in users). Turns out we also never tested this. D'oh! I've added some tests and walked through the code with Maneesh and I think this puts us in a better spot.

changeset-bot · 2022-08-18T17:57:29Z

🦋 Changeset detected

Latest commit: 437c652

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/auth	Patch
@firebase/auth-compat	Patch
firebase	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2022-08-18T18:19:01Z

Size Report ¹

Affected Products

`@firebase/auth`

Type	Base (`9f1e3c6`)	Merge (`c96e631`)	Diff
browser	155 kB	155 kB	-1 B (-0.0%)
cordova	183 kB	183 kB	-1 B (-0.0%)
esm5	203 kB	203 kB	-1 B (-0.0%)
main	148 kB	148 kB	-1 B (-0.0%)
module	155 kB	155 kB	-1 B (-0.0%)
react-native	168 kB	168 kB	-1 B (-0.0%)

@firebase/auth/cordova
Type Base (9f1e3c6) Merge (c96e631) Diff
browser 183 kB 183 kB -1 B (-0.0%)
module 183 kB 183 kB -1 B (-0.0%)
@firebase/auth/internal
Type Base (9f1e3c6) Merge (c96e631) Diff
browser 166 kB 166 kB -1 B (-0.0%)
esm5 216 kB 216 kB -1 B (-0.0%)
main 184 kB 184 kB -1 B (-0.0%)
module 166 kB 166 kB -1 B (-0.0%)
@firebase/auth/react-native
Type Base (9f1e3c6) Merge (c96e631) Diff
browser 168 kB 168 kB -1 B (-0.0%)
module 168 kB 168 kB -1 B (-0.0%)

`bundle`

Type	Base (`9f1e3c6`)	Merge (`c96e631`)	Diff
auth (Anonymous)	66.4 kB	66.4 kB	-1 B (-0.0%)
auth (EmailAndPassword)	70.5 kB	70.5 kB	-1 B (-0.0%)
auth (GoogleFBTwitterGitHubPopup)	90.4 kB	90.4 kB	-1 B (-0.0%)
auth (GooglePopup)	90.1 kB	90.1 kB	-1 B (-0.0%)
auth (GoogleRedirect)	90.3 kB	90.3 kB	-1 B (-0.0%)
auth (Phone)	76.6 kB	76.6 kB	-1 B (-0.0%)

`firebase`

Type	Base (`9f1e3c6`)	Merge (`c96e631`)	Diff
firebase-auth-compat.js	125 kB	125 kB	-2 B (-0.0%)
firebase-auth-cordova.js	137 kB	137 kB	-2 B (-0.0%)
firebase-auth-react-native.js	148 kB	148 kB	-2 B (-0.0%)
firebase-auth.js	116 kB	116 kB	-2 B (-0.0%)
firebase-compat.js	794 kB	794 kB	-2 B (-0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/xBMQwlIefc.html

maneesht

LGTM. Thanks for doing this!

google-oss-bot · 2022-08-18T18:33:00Z

Size Analysis Report ¹

Affected Products

@firebase/auth
- ActionCodeOperation
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.6 kB 31.6 kB -1 B (-0.0%)
  size-with-ext-deps 51.4 kB 51.4 kB -1 B (-0.0%)
- ActionCodeURL
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 32.5 kB 32.5 kB -1 B (-0.0%)
  size-with-ext-deps 52.5 kB 52.5 kB -1 B (-0.0%)
- AuthCredential
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.6 kB 31.6 kB -1 B (-0.0%)
  size-with-ext-deps 51.4 kB 51.4 kB -1 B (-0.0%)
- AuthErrorCodes
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 36.0 kB 36.0 kB -1 B (-0.0%)
  size-with-ext-deps 55.8 kB 55.8 kB -1 B (-0.0%)
- EmailAuthCredential
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 33.5 kB 33.5 kB -1 B (-0.0%)
  size-with-ext-deps 53.3 kB 53.3 kB -1 B (-0.0%)
- EmailAuthProvider
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 35.0 kB 35.0 kB -1 B (-0.0%)
  size-with-ext-deps 55.0 kB 55.0 kB -1 B (-0.0%)
- FacebookAuthProvider
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 36.6 kB 36.6 kB -1 B (-0.0%)
  size-with-ext-deps 56.3 kB 56.3 kB -1 B (-0.0%)
- FactorId
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.4 kB 31.4 kB -1 B (-0.0%)
  size-with-ext-deps 51.2 kB 51.2 kB -1 B (-0.0%)
- GithubAuthProvider
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 36.6 kB 36.6 kB -1 B (-0.0%)
  size-with-ext-deps 56.3 kB 56.3 kB -1 B (-0.0%)
- GoogleAuthProvider
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 36.6 kB 36.6 kB -1 B (-0.0%)
  size-with-ext-deps 56.3 kB 56.3 kB -1 B (-0.0%)
- OAuthCredential
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 33.6 kB 33.6 kB -1 B (-0.0%)
  size-with-ext-deps 53.4 kB 53.4 kB -1 B (-0.0%)
- OAuthProvider
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 37.5 kB 37.5 kB -1 B (-0.0%)
  size-with-ext-deps 57.3 kB 57.3 kB -1 B (-0.0%)
- OperationType
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.4 kB 31.4 kB -1 B (-0.0%)
  size-with-ext-deps 51.2 kB 51.2 kB -1 B (-0.0%)
- PhoneAuthCredential
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 33.6 kB 33.6 kB -1 B (-0.0%)
  size-with-ext-deps 53.4 kB 53.4 kB -1 B (-0.0%)
- PhoneAuthProvider
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 35.3 kB 35.3 kB -1 B (-0.0%)
  size-with-ext-deps 55.1 kB 55.1 kB -1 B (-0.0%)
- PhoneMultiFactorGenerator
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 32.4 kB 32.4 kB -1 B (-0.0%)
  size-with-ext-deps 52.1 kB 52.1 kB -1 B (-0.0%)
- ProviderId
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.5 kB 31.5 kB -1 B (-0.0%)
  size-with-ext-deps 51.3 kB 51.3 kB -1 B (-0.0%)
- RecaptchaVerifier
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 37.9 kB 37.9 kB -1 B (-0.0%)
  size-with-ext-deps 57.7 kB 57.7 kB -1 B (-0.0%)
- SAMLAuthProvider
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 37.8 kB 37.8 kB -1 B (-0.0%)
  size-with-ext-deps 57.6 kB 57.6 kB -1 B (-0.0%)
- SignInMethod
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.5 kB 31.5 kB -1 B (-0.0%)
  size-with-ext-deps 51.3 kB 51.3 kB -1 B (-0.0%)
- TwitterAuthProvider
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 36.6 kB 36.6 kB -1 B (-0.0%)
  size-with-ext-deps 56.3 kB 56.3 kB -1 B (-0.0%)
- applyActionCode
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.6 kB 31.6 kB -1 B (-0.0%)
  size-with-ext-deps 51.4 kB 51.4 kB -1 B (-0.0%)
- beforeAuthStateChanged
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.4 kB 31.4 kB -1 B (-0.0%)
  size-with-ext-deps 51.2 kB 51.2 kB -1 B (-0.0%)
- browserLocalPersistence
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 34.8 kB 34.8 kB -1 B (-0.0%)
  size-with-ext-deps 54.7 kB 54.7 kB -1 B (-0.0%)
- browserPopupRedirectResolver
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 55.8 kB 55.8 kB -1 B (-0.0%)
  size-with-ext-deps 75.8 kB 75.8 kB -1 B (-0.0%)
- browserSessionPersistence
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 34.8 kB 34.8 kB -1 B (-0.0%)
  size-with-ext-deps 54.7 kB 54.7 kB -1 B (-0.0%)
- checkActionCode
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 32.6 kB 32.6 kB -1 B (-0.0%)
  size-with-ext-deps 52.3 kB 52.3 kB -1 B (-0.0%)
- confirmPasswordReset
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.6 kB 31.6 kB -1 B (-0.0%)
  size-with-ext-deps 51.4 kB 51.4 kB -1 B (-0.0%)
- connectAuthEmulator
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 33.1 kB 33.1 kB -1 B (-0.0%)
  size-with-ext-deps 52.9 kB 52.9 kB -1 B (-0.0%)
- createUserWithEmailAndPassword
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 32.5 kB 32.5 kB -1 B (-0.0%)
  size-with-ext-deps 52.3 kB 52.3 kB -1 B (-0.0%)
- debugErrorMap
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 42.5 kB 42.5 kB -1 B (-0.0%)
  size-with-ext-deps 62.3 kB 62.3 kB -1 B (-0.0%)
- deleteUser
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.4 kB 31.4 kB -1 B (-0.0%)
  size-with-ext-deps 51.2 kB 51.2 kB -1 B (-0.0%)
- fetchSignInMethodsForEmail
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.8 kB 31.8 kB -1 B (-0.0%)
  size-with-ext-deps 51.6 kB 51.6 kB -1 B (-0.0%)
- getAdditionalUserInfo
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 32.7 kB 32.7 kB -1 B (-0.0%)
  size-with-ext-deps 52.5 kB 52.5 kB -1 B (-0.0%)
- getAuth
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 63.5 kB 63.5 kB -1 B (-0.0%)
  size-with-ext-deps 84.1 kB 84.1 kB -1 B (-0.0%)
- getIdToken
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.4 kB 31.4 kB -1 B (-0.0%)
  size-with-ext-deps 51.2 kB 51.2 kB -1 B (-0.0%)
- getIdTokenResult
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.4 kB 31.4 kB -1 B (-0.0%)
  size-with-ext-deps 51.1 kB 51.1 kB -1 B (-0.0%)
- getMultiFactorResolver
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 34.1 kB 34.1 kB -1 B (-0.0%)
  size-with-ext-deps 53.9 kB 53.9 kB -1 B (-0.0%)
- getRedirectResult
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 39.0 kB 39.0 kB -1 B (-0.0%)
  size-with-ext-deps 58.8 kB 58.8 kB -1 B (-0.0%)
- inMemoryPersistence
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.4 kB 31.4 kB -1 B (-0.0%)
  size-with-ext-deps 51.1 kB 51.1 kB -1 B (-0.0%)
- indexedDBLocalPersistence
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 38.8 kB 38.8 kB -1 B (-0.0%)
  size-with-ext-deps 58.6 kB 58.6 kB -1 B (-0.0%)
- initializeAuth
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.6 kB 31.6 kB -1 B (-0.0%)
  size-with-ext-deps 51.9 kB 51.9 kB -1 B (-0.0%)
- isSignInWithEmailLink
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 32.6 kB 32.6 kB -1 B (-0.0%)
  size-with-ext-deps 52.6 kB 52.6 kB -1 B (-0.0%)
- linkWithCredential
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 32.4 kB 32.4 kB -1 B (-0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB -1 B (-0.0%)
- linkWithPhoneNumber
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 36.1 kB 36.1 kB -1 B (-0.0%)
  size-with-ext-deps 55.9 kB 55.9 kB -1 B (-0.0%)
- linkWithPopup
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 42.6 kB 42.6 kB -1 B (-0.0%)
  size-with-ext-deps 62.4 kB 62.4 kB -1 B (-0.0%)
- linkWithRedirect
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 37.8 kB 37.8 kB -1 B (-0.0%)
  size-with-ext-deps 57.6 kB 57.6 kB -1 B (-0.0%)
- multiFactor
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 33.6 kB 33.6 kB -1 B (-0.0%)
  size-with-ext-deps 53.4 kB 53.4 kB -1 B (-0.0%)
- onAuthStateChanged
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.4 kB 31.4 kB -1 B (-0.0%)
  size-with-ext-deps 51.2 kB 51.2 kB -1 B (-0.0%)
- onIdTokenChanged
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.4 kB 31.4 kB -1 B (-0.0%)
  size-with-ext-deps 51.2 kB 51.2 kB -1 B (-0.0%)
- parseActionCodeURL
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 32.5 kB 32.5 kB -1 B (-0.0%)
  size-with-ext-deps 52.5 kB 52.5 kB -1 B (-0.0%)
- prodErrorMap
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.4 kB 31.4 kB -1 B (-0.0%)
  size-with-ext-deps 51.1 kB 51.1 kB -1 B (-0.0%)
- reauthenticateWithCredential
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 33.0 kB 33.0 kB -1 B (-0.0%)
  size-with-ext-deps 52.8 kB 52.8 kB -1 B (-0.0%)
- reauthenticateWithPhoneNumber
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 36.6 kB 36.6 kB -1 B (-0.0%)
  size-with-ext-deps 56.4 kB 56.4 kB -1 B (-0.0%)
- reauthenticateWithPopup
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 42.6 kB 42.6 kB -1 B (-0.0%)
  size-with-ext-deps 62.4 kB 62.4 kB -1 B (-0.0%)
- reauthenticateWithRedirect
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 37.6 kB 37.6 kB -1 B (-0.0%)
  size-with-ext-deps 57.3 kB 57.3 kB -1 B (-0.0%)
- reload
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.4 kB 31.4 kB -1 B (-0.0%)
  size-with-ext-deps 51.1 kB 51.1 kB -1 B (-0.0%)
- sendEmailVerification
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 32.4 kB 32.4 kB -1 B (-0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB -1 B (-0.0%)
- sendPasswordResetEmail
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 32.3 kB 32.3 kB -1 B (-0.0%)
  size-with-ext-deps 52.1 kB 52.1 kB -1 B (-0.0%)
- sendSignInLinkToEmail
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 32.4 kB 32.4 kB -1 B (-0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB -1 B (-0.0%)
- setPersistence
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.4 kB 31.4 kB -1 B (-0.0%)
  size-with-ext-deps 51.2 kB 51.2 kB -1 B (-0.0%)
- signInAnonymously
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 32.7 kB 32.7 kB -1 B (-0.0%)
  size-with-ext-deps 52.4 kB 52.4 kB -1 B (-0.0%)
- signInWithCredential
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 32.8 kB 32.8 kB -1 B (-0.0%)
  size-with-ext-deps 52.5 kB 52.5 kB -1 B (-0.0%)
- signInWithCustomToken
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 32.5 kB 32.5 kB -1 B (-0.0%)
  size-with-ext-deps 52.3 kB 52.3 kB -1 B (-0.0%)
- signInWithEmailAndPassword
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 36.4 kB 36.4 kB -1 B (-0.0%)
  size-with-ext-deps 56.4 kB 56.4 kB -1 B (-0.0%)
- signInWithEmailLink
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 36.6 kB 36.6 kB -1 B (-0.0%)
  size-with-ext-deps 56.6 kB 56.6 kB -1 B (-0.0%)
- signInWithPhoneNumber
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 36.4 kB 36.4 kB -1 B (-0.0%)
  size-with-ext-deps 56.2 kB 56.2 kB -1 B (-0.0%)
- signInWithPopup
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 42.6 kB 42.6 kB -1 B (-0.0%)
  size-with-ext-deps 62.4 kB 62.4 kB -1 B (-0.0%)
- signInWithRedirect
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 37.3 kB 37.3 kB -1 B (-0.0%)
  size-with-ext-deps 57.1 kB 57.1 kB -1 B (-0.0%)
- signOut
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.4 kB 31.4 kB -1 B (-0.0%)
  size-with-ext-deps 51.2 kB 51.2 kB -1 B (-0.0%)
- unlink
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 32.0 kB 32.0 kB -1 B (-0.0%)
  size-with-ext-deps 51.7 kB 51.7 kB -1 B (-0.0%)
- updateCurrentUser
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.4 kB 31.4 kB -1 B (-0.0%)
  size-with-ext-deps 51.2 kB 51.2 kB -1 B (-0.0%)
- updateEmail
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.7 kB 31.7 kB -1 B (-0.0%)
  size-with-ext-deps 51.5 kB 51.5 kB -1 B (-0.0%)
- updatePassword
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.7 kB 31.7 kB -1 B (-0.0%)
  size-with-ext-deps 51.5 kB 51.5 kB -1 B (-0.0%)
- updatePhoneNumber
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 32.1 kB 32.1 kB -1 B (-0.0%)
  size-with-ext-deps 51.9 kB 51.9 kB -1 B (-0.0%)
- updateProfile
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.9 kB 31.9 kB -1 B (-0.0%)
  size-with-ext-deps 51.7 kB 51.7 kB -1 B (-0.0%)
- useDeviceLanguage
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 31.4 kB 31.4 kB -1 B (-0.0%)
  size-with-ext-deps 51.2 kB 51.2 kB -1 B (-0.0%)
- verifyBeforeUpdateEmail
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 32.5 kB 32.5 kB -1 B (-0.0%)
  size-with-ext-deps 52.2 kB 52.2 kB -1 B (-0.0%)
- verifyPasswordResetCode
  Size
  Type Base (9f1e3c6) Merge (c7609d1) Diff
  size 32.6 kB 32.6 kB -1 B (-0.0%)
  size-with-ext-deps 52.4 kB 52.4 kB -1 B (-0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/rL9s2KqKF3.html

prameshj · 2022-08-18T19:20:36Z

/lgtm

Thanks for fixing!

Fix proactive refresh logic, add some tests

1ca2c37

sam-gc requested a review from avolkovi as a code owner August 18, 2022 17:57

sam-gc assigned maneesht Aug 18, 2022

sam-gc requested review from lisajian and yuchenshi as code owners August 18, 2022 17:57

sam-gc assigned yuchenshi and prameshj Aug 18, 2022

Changeset

437c652

sam-gc requested a review from egilmorez as a code owner August 18, 2022 17:58

maneesht approved these changes Aug 18, 2022

View reviewed changes

yuchenshi approved these changes Aug 19, 2022

View reviewed changes

sam-gc merged commit bea604e into master Aug 19, 2022

sam-gc deleted the sam-gc/proactive branch August 19, 2022 15:43

google-oss-bot mentioned this pull request Aug 31, 2022

Version Packages #6574

Merged

firebase locked and limited conversation to collaborators Sep 19, 2022

Fix proactive refresh logic, add some tests #6544

Fix proactive refresh logic, add some tests #6544

Conversation

sam-gc commented Aug 18, 2022

changeset-bot bot commented Aug 18, 2022 • edited Loading

🦋 Changeset detected

google-oss-bot commented Aug 18, 2022 • edited Loading

Size Report 1

Affected Products

@firebase/auth

@firebase/auth/cordova

@firebase/auth/internal

@firebase/auth/react-native

bundle

firebase

Test Logs

maneesht left a comment

Choose a reason for hiding this comment

google-oss-bot commented Aug 18, 2022 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/auth

ActionCodeOperation

ActionCodeURL

AuthCredential

AuthErrorCodes

EmailAuthCredential

EmailAuthProvider

FacebookAuthProvider

FactorId

GithubAuthProvider

GoogleAuthProvider

OAuthCredential

OAuthProvider

OperationType

PhoneAuthCredential

PhoneAuthProvider

PhoneMultiFactorGenerator

ProviderId

RecaptchaVerifier

SAMLAuthProvider

SignInMethod

TwitterAuthProvider

applyActionCode

beforeAuthStateChanged

browserLocalPersistence

browserPopupRedirectResolver

browserSessionPersistence

checkActionCode

confirmPasswordReset

connectAuthEmulator

createUserWithEmailAndPassword

debugErrorMap

deleteUser

fetchSignInMethodsForEmail

getAdditionalUserInfo

getAuth

getIdToken

getIdTokenResult

getMultiFactorResolver

getRedirectResult

inMemoryPersistence

indexedDBLocalPersistence

initializeAuth

isSignInWithEmailLink

linkWithCredential

linkWithPhoneNumber

linkWithPopup

linkWithRedirect

multiFactor

onAuthStateChanged

onIdTokenChanged

parseActionCodeURL

prodErrorMap

reauthenticateWithCredential

reauthenticateWithPhoneNumber

reauthenticateWithPopup

reauthenticateWithRedirect

reload

sendEmailVerification

changeset-bot bot commented Aug 18, 2022 •

edited

Loading

google-oss-bot commented Aug 18, 2022 •

edited

Loading

Size Report ¹

`@firebase/auth`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/auth/react-native`

`bundle`

`firebase`

google-oss-bot commented Aug 18, 2022 •

edited

Loading

Size Analysis Report ¹

`@firebase/auth`

`ActionCodeOperation`

`ActionCodeURL`

`AuthCredential`

`AuthErrorCodes`

`EmailAuthCredential`

`EmailAuthProvider`

`FacebookAuthProvider`

`FactorId`

`GithubAuthProvider`

`GoogleAuthProvider`

`OAuthCredential`

`OAuthProvider`

`OperationType`

`PhoneAuthCredential`

`PhoneAuthProvider`

`PhoneMultiFactorGenerator`

`ProviderId`

`RecaptchaVerifier`

`SAMLAuthProvider`

`SignInMethod`

`TwitterAuthProvider`

`applyActionCode`

`beforeAuthStateChanged`

`browserLocalPersistence`

`browserPopupRedirectResolver`

`browserSessionPersistence`

`checkActionCode`

`confirmPasswordReset`

`connectAuthEmulator`

`createUserWithEmailAndPassword`

`debugErrorMap`

`deleteUser`

`fetchSignInMethodsForEmail`

`getAdditionalUserInfo`

`getAuth`

`getIdToken`

`getIdTokenResult`

`getMultiFactorResolver`

`getRedirectResult`

`inMemoryPersistence`

`indexedDBLocalPersistence`

`initializeAuth`

`isSignInWithEmailLink`

`linkWithCredential`

`linkWithPhoneNumber`

`linkWithPopup`

`linkWithRedirect`

`multiFactor`

`onAuthStateChanged`

`onIdTokenChanged`

`parseActionCodeURL`

`prodErrorMap`

`reauthenticateWithCredential`

`reauthenticateWithPhoneNumber`

`reauthenticateWithPopup`

`reauthenticateWithRedirect`

`reload`

`sendEmailVerification`

`sendPasswordResetEmail`

`sendSignInLinkToEmail`

`setPersistence`

`signInAnonymously`

`signInWithCredential`

`signInWithCustomToken`

`signInWithEmailAndPassword`

`signInWithEmailLink`

`signInWithPhoneNumber`

`signInWithPopup`