Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix documentation typo #6583

Merged
merged 4 commits into from
Oct 3, 2022
Merged

fix documentation typo #6583

merged 4 commits into from
Oct 3, 2022

Conversation

tylim88
Copy link
Contributor

@tylim88 tylim88 commented Sep 5, 2022

push typo
image

endBefore typo
image

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2022

🦋 Changeset detected

Latest commit: f3fb67b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/database Patch
@firebase/database-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tylim88 tylim88 changed the title fix typo of documentation in code Sep 6, 2022
@maneesht maneesht requested a review from egilmorez as a code owner September 7, 2022 20:36
@maneesht
Copy link
Contributor

maneesht commented Sep 7, 2022

@tylim88 - can you please fix the formatting issue?

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG from a docs perspective, thanks for catching and sending!

@maneesht maneesht merged commit 5aa48d0 into firebase:master Oct 3, 2022
@google-oss-bot google-oss-bot mentioned this pull request Oct 10, 2022
@firebase firebase locked and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants