Upgrade TypeScript to 4.7.4 #6682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 915f8df The changes in this PR will be included in the next version bump. This PR includes changesets to release 46 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
hsubox76
force-pushed
the
ch-ts-upgrade
branch
from
3e082cf to
5848943
Compare
Changeset File Check ✅
|
hsubox76
requested review from
egilmorez,
avolkovi,
sam-gc,
yuchenshi and
dwyfrequency
as code owners
Size Analysis Report 1Affected Products
Test Logs |
hsubox76
force-pushed
the
ch-ts-upgrade
branch
from
f1a7825 to
4de31e0
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to upgrade our TypeScript version, it's still at 4.2.2 and the latest is 4.8.4. We are going to try for a little behind the latest version, because some of our other deps have dependencies on TypeScript and may lag a little on which version they support. So we'll try for 4.7.4, the last 4.7.* release.
Most of the necessary updates (e.g. adding types to caught errors) have already been done by @dwyfrequency in previous PRs.
The most notable fix here is that TypeScript 4.3 introduced the ability for TS to recognize
{@linkstatements in comments, which caused it to break up comments into multiple nodes which caused some assumptions inprune-dtsto break.Also updated deprecated methods in
prune-dts(Firestore-only script that intercepts api-extractor and does some extra things) andcreate-overloads(adds typings to compat d.ts files to enable users to use compat and modular instances in the same code) scripts.