Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'icon' to '/messaging-types' #6728

Merged
merged 5 commits into from
Nov 1, 2022
Merged

Add 'icon' to '/messaging-types' #6728

merged 5 commits into from
Nov 1, 2022

Conversation

zwu52
Copy link
Member

@zwu52 zwu52 commented Oct 26, 2022

This follows #6722 to supplement 'icon' also to the '/messaging-types' dir.

ref: b/241885017

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2022

🦋 Changeset detected

Latest commit: 8a0ca1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/messaging Minor
firebase Patch
@firebase/messaging-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@@ -31,6 +31,7 @@ export interface NotificationPayload {
title?: string;
body?: string;
image?: string;
icon?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity I looked to see if this package (@firebase/messaging-types) is being used anywhere and it doesn't seem to be? I see it as a dependency in packages/messaging/package.json but I don't see it imported anywhere in the source code. The other instances of [product]-types packages we have are legacy typings that are only used by [product]-compat but messaging-compat doesn't seem to use anything from it, and regular v9 messaging also doesn't. Maybe we could remove it? (in a later PR)

@zwu52 zwu52 merged commit 9e9ee7b into master Nov 1, 2022
@zwu52 zwu52 deleted the add_icon branch November 1, 2022 21:18
@google-oss-bot google-oss-bot mentioned this pull request Nov 8, 2022
@firebase firebase locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants