Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OR Query public API #7053

Merged
merged 16 commits into from
Mar 6, 2023
Merged

OR Query public API #7053

merged 16 commits into from
Mar 6, 2023

Conversation

MarkDuckworth
Copy link
Contributor

Adding the OR Query public API
@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 8e32951

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Minor
firebase Minor
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 22, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (722325a) and merge commit (af3ce1b).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Spr0AHl7tK.html
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 22, 2023 •
edited
Loading

Size Analysis Report 1

This report is too large (716,213 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EeCkQifUvp.html
@MarkDuckworth
Copy link
Contributor Author

@egilmorez please take a look at these documentation changes for the public API for the upcoming OR query feature.
@MarkDuckworth
Merge branch 'markduckworth/public-or-queries' of github.com:firebase…
0ca3c7f 
…/firebase-js-sdk into markduckworth/public-or-queries
egilmorez
egilmorez reviewed Feb 23, 2023
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One high-level question before we pass the review to Mark A., thanks!
@ehsannas ehsannas assigned MarkDuckworth and unassigned ehsannas Feb 24, 2023
egilmorez
egilmorez reviewed Feb 24, 2023
View reviewed changes
docs-devsite/firestore_lite.querycompositefilterconstraint.md
@@ -0,0 +1,35 @@
Project: /docs/reference/js/_project.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I forget to press a button earlier today . . . ??

Anyway, my question was: why are these output files included in the PR? Generally we do those in a follow-on CL. Thanks!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@egilmorez, this is a required CI step now. PR's that will result in a public documentation change will include updates to the docs-devsite/ folder.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@egilmorez ... wrt to the feature, this content looks fine. Do you want resolution to this discussion before I give the single approval that will unblock?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, go ahead Mark, thanks! I'm curious see if a doc CL crosses my "desk."
dwyfrequency
dwyfrequency reviewed Mar 1, 2023
View reviewed changes
.changeset/sweet-rats-compete.md Outdated
@@ -0,0 +1,5 @@
---
"@firebase/firestore": feat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to

'@firebase/firestore': minor
'firebase': minor
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified. Thank you for the review.
egilmorez
egilmorez approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iiuc, all the doc strings are in query.ts and reference.ts, both of which look fine to me.
dwyfrequency
dwyfrequency approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ehsannas ehsannas merged commit 5ba5243 into master Mar 6, 2023
@ehsannas ehsannas deleted the markduckworth/public-or-queries branch March 6, 2023 17:43
@google-oss-bot google-oss-bot mentioned this pull request Mar 14, 2023
Merged
renkelvin pushed a commit that referenced this pull request Mar 21, 2023
@MarkDuckworth
OR Query public API (#7053)
52f249e 
* Relaxing in restrictions.

* Additional testing.

* Relaxing query restrictions.

* Code cleanup.

* Removing compat tests that perform validation on the old query restrictions.

* Making OR Queries public.

* Enabling tests for or queries and configuring tests that require composite indexes to only run against the emulator.

* Create sweet-rats-compete.md

* Fixing documentation errors revealed by the doc change check.

* Removing and renaming tests based on PR feedback.

* Correcting the change type in the changeset file.

* Disable tests that have multiple ins or array-contains-any per query.
renkelvin pushed a commit that referenced this pull request Mar 21, 2023
@MarkDuckworth
OR Query public API (#7053)
23dc80b 
* Relaxing in restrictions.

* Additional testing.

* Relaxing query restrictions.

* Code cleanup.

* Removing compat tests that perform validation on the old query restrictions.

* Making OR Queries public.

* Enabling tests for or queries and configuring tests that require composite indexes to only run against the emulator.

* Create sweet-rats-compete.md

* Fixing documentation errors revealed by the doc change check.

* Removing and renaming tests based on PR feedback.

* Correcting the change type in the changeset file.

* Disable tests that have multiple ins or array-contains-any per query.
@firebase firebase locked and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
6 participants
@MarkDuckworth @google-oss-bot @ehsannas @egilmorez @dwyfrequency @markarndt