Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide ESM modules from webchannel-wrapper #7228

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Provide ESM modules from webchannel-wrapper #7228

merged 2 commits into from
Apr 17, 2023

Conversation

hsubox76
Copy link
Contributor

Use emitModulePackageFile plugin to ensure consumers looking for ES modules can get one from the webchannel-wrapper package.
@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2023 •
edited
Loading

�� Changeset detected

Latest commit: f6f286a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@firebase/webchannel-wrapper Patch
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR
@dconeybe dconeybe mentioned this pull request Apr 14, 2023
Closed
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 14, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (ecb4454) and merge commit (c0ef6d0).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MaCQMSjMoR.html
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 14, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (ecb4454) and merge commit (c0ef6d0).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/QUXexwHsmZ.html
@hsubox76 hsubox76 marked this pull request as ready for review April 14, 2023 18:52
dwyfrequency
dwyfrequency approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@dconeybe dconeybe mentioned this pull request Apr 15, 2023
Merged
@hsubox76 hsubox76 merged commit 5e5c412 into master Apr 17, 2023
@hsubox76 hsubox76 deleted the ch-ww-esm branch April 17, 2023 16:48
@google-oss-bot google-oss-bot mentioned this pull request Apr 25, 2023
Merged
@firebase firebase locked and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants
@hsubox76 @google-oss-bot @dwyfrequency