-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for App Check replay protection in callable functions #7296
Conversation
🦋 Changeset detectedLatest commit: 2ca507c The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b765a5d
to
f0119d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LG, one suggestion to streamline the test.
For the PR process:
- This will need a changeset (
yarn changeset
will automatically help you add the packages (should be patch for app-check and minor for functions) but you'll also need to add'firebase': minor
manually beneath those. - This will make a docs change, you'll need to run
yarn docgen devsite
and check in chagnes to thedocs-devsite
dir and have them reviewed by the appropriate tech writer for App Check which I think is @kevinthecheung
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG - make sure you get tech writer review before merging.
Also can you add a description? Can just be a link to the design doc/API proposal, it's fine if it's internal, you can just say (internal doc)
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
fb6e91b
to
178e420
Compare
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
internal API proposal: go/fac-1-use-callable-sdk