Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print message to view Firestore database in console after creation or restore #6949

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

rwhogg
Copy link
Contributor

@rwhogg rwhogg commented Apr 2, 2024

Description

After you create a Firestore database, we will now display a link to that database in the Firebase console.

We also do this after you restore a Firestore database, but also note that you should wait until the restore is finished before using it.

Scenarios Tested

  • Creating (default) database
  • Creating non-(default) database
  • Restoring to the (default) database
  • Restoring to a non-(default) database

Examples

  • Creating the (default) database
% firebase firestore:databases:create --location us-east1 --project example-project '(default)'
Successfully created projects/example-project/databases/(default)
Please be sure to configure Firebase rules in your Firebase config file for
the new database. By default, created databases will have closed rules that
block any incoming third-party traffic.
Your database may be viewed at https://console.firebase.google.com/project/example-project/firestore/databases/-default-/data
  • Creating a non-(default) database
% firebase firestore:databases:create --location us-east1 --project example-project 'other-database'
Successfully created projects/example-project/databases/other-database
Please be sure to configure Firebase rules in your Firebase config file for
the new database. By default, created databases will have closed rules that
block any incoming third-party traffic.
Your database may be viewed at https://console.firebase.google.com/project/example-project/firestore/databases/other-database/data
  • Restoring to the (default) database
% firebase firestore:databases:restore --backup projects/example-project/locations/europe-west2/backups/ce2d2a2d-679e-403f-bab7-888f1d68afc3 --database '(default)'
Successfully initiated restore of projects/example-project/databases/(default)
Please be sure to configure Firebase rules in your Firebase config file for
the new database. By default, created databases will have closed rules that
block any incoming third-party traffic.
Once the restore is complete, your database may be viewed at https://console.firebase.google.com/project/example-project/firestore/databases/-default-/data
@rwhogg rwhogg requested a review from VicVer09 April 2, 2024 20:03
@rwhogg rwhogg force-pushed the rh-fb-console-link-dbcreate branch 2 times, most recently from 5fee5cf to e7768fc Compare April 2, 2024 20:09
Copy link
Contributor

@VicVer09 VicVer09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending rebase and a more detailed description with some screenshots

@rwhogg rwhogg force-pushed the rh-fb-console-link-dbcreate branch from e7768fc to aff1b8f Compare April 3, 2024 14:16
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.79%. Comparing base (0b770fe) to head (aff1b8f).
Report is 2 commits behind head on master.

Files Patch % Lines
src/firestore/pretty-print.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6949      +/-   ##
==========================================
- Coverage   54.79%   54.79%   -0.01%     
==========================================
  Files         359      359              
  Lines       25059    25061       +2     
  Branches     5166     5166              
==========================================
+ Hits        13732    13733       +1     
- Misses      10090    10091       +1     
  Partials     1237     1237              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwhogg rwhogg force-pushed the rh-fb-console-link-dbcreate branch from aff1b8f to 1ea4742 Compare April 3, 2024 14:51
@rwhogg rwhogg requested a review from joehan April 3, 2024 15:15
@rwhogg rwhogg self-assigned this Apr 3, 2024
@rwhogg rwhogg marked this pull request as ready for review April 3, 2024 15:15
@rwhogg rwhogg marked this pull request as draft April 3, 2024 16:54
@rwhogg rwhogg marked this pull request as ready for review April 5, 2024 18:56
@rwhogg rwhogg force-pushed the rh-fb-console-link-dbcreate branch 2 times, most recently from 5f93c9e to b29b3df Compare April 9, 2024 17:58
@rwhogg rwhogg force-pushed the rh-fb-console-link-dbcreate branch from b29b3df to 16fe79d Compare April 9, 2024 19:03
@rwhogg rwhogg merged commit 45b5491 into master Apr 10, 2024
35 checks passed
@rwhogg rwhogg deleted the rh-fb-console-link-dbcreate branch April 10, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants