Support firebase dataconnect:sdk:generate --watch
#7719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredzqm
reviewed
Sep 23, 2024
| @@ -8,9 +8,11 @@ import { load } from "../dataconnect/load"; | |||
| import { readFirebaseJson } from "../dataconnect/fileUtils"; | |||
| import { logger } from "../logger"; | |||
|
|
|||
| type GenerateOptions = Options & { watch?: boolean }; | |||
There was a problem hiding this comment.
[Can be defered] [Not blocking PP, lower priority than compatible modes docs]
While we are at this. It would nice if sdk:generate also takes optional [serviceId] [connectorId] like other commands.
The rule of thumb from go/fdc:multi-data-source: if there are >1 services / connectors / datasource, it defaults to run the same routine against all relevant resources.
dataconnect:services:list list all deployed services in your Firebase
project
dataconnect:sql:diff [serviceId] displays the differences between a local
DataConnect schema and your CloudSQL database's
current schema
dataconnect:sql:migrate [options] [serviceId] migrates your CloudSQL database's schema to
match your local DataConnect schema
dataconnect:sql:grant [options] [serviceId] Grants the SQL role <role> to the provided user
or service account <email>.
dataconnect:sdk:generate generates typed SDKs for your Data Connect
connectors
There was a problem hiding this comment.
Filed b/369400626 to update all commands per go/fdc:multi-data-source, as I believe right now an error is thrown in diff/migrate/grant if serviceId isn't specified and multiple services exist.
joehan
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scenarios Tested
Sample Commands