Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Crashes on get FirebaseAuth.CurrentUser.UserId #733

Closed
amoswazana opened this issue May 24, 2023 · 4 comments
Closed

[Bug] Crashes on get FirebaseAuth.CurrentUser.UserId #733

amoswazana opened this issue May 24, 2023 · 4 comments
Labels
api: auth needs-info Need information for the developer type: question

Comments

@amoswazana
Copy link

[REQUIRED] Please fill in the following fields:

  • Unity editor version: 2021.3.25f1
  • Firebase Unity SDK version: 11.0.0
  • Source you installed the SDK: .unityPackage
  • Problematic Firebase Component: Auth
  • Other Firebase Components in use: Auth, Firestore, DynamicLinks, Analytics, Crashlytics, Functions, Messaging
  • Additional SDKs you are using: Admob, Admob mediation (Unity, AdColony, AppLovin, InMobi), Photon, Unity Purchasing
  • Platform you are using the Unity editor on: Mac
  • Platform you are targeting: iOS, Android, WebGL
  • Scripting Runtime: IL2CPP
  • Pre-built SDK from the website or open-source from this repo: pre-built

[REQUIRED] Please describe the issue here:

We have noticed a new crash in our app, caused by the line auth.CurrentUser.UserId.
Relevant crash logs from Google Play Console (replaced our app name with com.appname):

backtrace:
  #00  pc 0x00000000002ba7b4  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libFirebaseCppApp-11_0_0.so (firebase::auth::User::is_valid() const+8)
  #01  pc 0x00000000001fc600  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libFirebaseCppApp-11_0_0.so (Firebase_Auth_CSharp_FirebaseUser_IsValid+12)
  #02  pc 0x0000000000851ee4  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libil2cpp.so (AuthUtilPINVOKE_FirebaseUser_IsValid_m8506CC0BE369BBEFD83BBC02F1777C140A16299F)
  #03  pc 0x0000000000851e10  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libil2cpp.so (FirebaseUser_IsValid_m745FA6B0AF38AF4988B188E019F0621C27DED2DA)
  #04  pc 0x000000000085415c  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libil2cpp.so (FirebaseAuth_UpdateCurrentUser_m8C0906D45788F454E7E19A8C929FEBA42792A06B)
  #05  pc 0x00000000015f77cc  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libil2cpp.so (FirebaseAsyncOperationsLayer_get_CurrentUserID_m3803590513CE5532AE611E61B67A55578DEBE52A)
  #06  pc 0x0000000001609f88  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libil2cpp.so (LoginMaster_LoginComplete_mC3FEC58E92D4595BD52CE71AE0E2608565311617)
  #07  pc 0x0000000001676c48  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libil2cpp.so (BaseFirebaseManager_Update_mA0BD31D4C48A63E7226E28F3BFD84F645A35D022)
  #08  pc 0x0000000000708d40  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libil2cpp.so (il2cpp::vm::Runtime::InvokeWithThrow(MethodInfo const*, void*, void**))
  #09  pc 0x0000000000708bb4  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libil2cpp.so (il2cpp::vm::Runtime::Invoke(MethodInfo const*, void*, void**, Il2CppException**))
  #10  pc 0x00000000002a314c  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libunity.so (scripting_method_invoke(ScriptingMethodPtr, ScriptingObjectPtr, ScriptingArguments&, ScriptingExceptionPtr*, bool))
  #11  pc 0x00000000002b1c4c  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libunity.so (ScriptingInvocation::Invoke(ScriptingExceptionPtr*, bool))
  #12  pc 0x00000000002bf644  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libunity.so (MonoBehaviour::CallUpdateMethod(int))
  #13  pc 0x000000000015af40  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libunity.so (void BaseBehaviourManager::CommonUpdate<BehaviourManager>())
  #14  pc 0x00000000001efc80  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libunity.so (ExecutePlayerLoop(NativePlayerLoopSystem*))
  #15  pc 0x00000000001efcc0  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libunity.so (ExecutePlayerLoop(NativePlayerLoopSystem*))
  #16  pc 0x00000000001efef8  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libunity.so (PlayerLoop())
  #17  pc 0x000000000032d1c0  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libunity.so (UnityPlayerLoop())
  #18  pc 0x00000000003437f4  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/lib/arm64/libunity.so (nativeRender(_JNIEnv*, _jobject*))
  #19  pc 0x00000000000b7b4c  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/oat/arm64/base.odex (art_jni_trampoline+124)
  #20  pc 0x000000000019f19c  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/oat/arm64/base.odex (com.unity3d.player.UnityPlayer$e$1.handleMessage+972)
  #21  pc 0x0000000000649ee8  /system/framework/arm64/boot-framework.oat (android.os.Handler.dispatchMessage+136)
  #22  pc 0x000000000064d560  /system/framework/arm64/boot-framework.oat (android.os.Looper.loop+1696)
  #23  pc 0x000000000019fda8  /data/app/~~mEbfahJdQHVXzJfHkmJ1sQ==/com.appname-QNl3qhFgfFnaksjT2yAViQ==/oat/arm64/base.odex (com.unity3d.player.UnityPlayer$e.run+216)
  #24  pc 0x0000000000133564  /apex/com.android.art/lib64/libart.so (art_quick_invoke_stub+548)
  #25  pc 0x00000000001a8a78  /apex/com.android.art/lib64/libart.so (art::ArtMethod::Invoke(art::Thread*, unsigned int*, unsigned int, art::JValue*, char const*)+200)
  #26  pc 0x0000000000554e34  /apex/com.android.art/lib64/libart.so (art::JValue art::InvokeVirtualOrInterfaceWithJValues<art::ArtMethod*>(art::ScopedObjectAccessAlreadyRunnable const&, _jobject*, art::ArtMethod*, jvalue const*)+460)
  #27  pc 0x00000000005a41d0  /apex/com.android.art/lib64/libart.so (art::Thread::CreateCallback(void*)+1308)
  #28  pc 0x00000000000eb968  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+64)
  #29  pc 0x000000000008bb88  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64)

Steps to reproduce:

Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)?
No. We currently do not have a device that can reproduce this issue.
What's the issue repro rate?
We currently have 500+ users that have experienced this crash.

What happened? How can we make the problem occur?
The crash happens when we call auth.CurrentUser.UserId.

If you have a downloadable sample project that reproduces the bug you're reporting, you will
likely receive a faster response on your issue.

Relevant Code:

    // example flow
    using Firebase;
    using Firebase.Auth;

    private FirebaseAuth auth;
    private IEnumerator FirebaseAuthFlow(string email, string password) {
        bool isReadyForFirebaseOperations = false;
        FirebaseApp.CheckAndFixDependenciesAsync().ContinueWithOnMainThread(task => {
            var dependencyStatus = task.Result;
            if (dependencyStatus == Firebase.DependencyStatus.Available) {
                auth = FirebaseAuth.DefaultInstance;
                isReadyForFirebaseOperations = true;
            } else {
                Debug.Log($"Could not resolve all Firebase dependencies: {dependencyStatus}");
            }
        });

        while (isReadyForFirebaseOperations) {
            yield return null;
        }

        bool success = false;
        bool signInRunning = true;

        auth.SignInWithEmailAndPasswordAsync(email, password).ContinueWith((t) => {
            if (t.IsFaulted || t.IsCanceled) {
                Debug.Log($"EmailLogin faulted or canceled. faulted: {t.IsFaulted}, canceled: {t.IsCanceled}, message: {t.Exception}");
            } else {
                success = true;
            }
            signInRunning = false;
        });

        while(signInRunning) {
            yield return null;
        }

        if(success) {
            // This crashes the app on certain devices
            Debug.Log(auth.CurrentUser.UserId);
        }
    }
@paulinon paulinon added api: auth and removed new New issue. labels May 24, 2023
@paulinon
Copy link
Contributor

Hi @amoswazana,

Thanks for reporting this issue. In order to identify what's causing this to happen, could you provide details about the devices facing this crash? These details may include but are not limited to the Android OS version, device brand, and model.

@paulinon paulinon added the needs-info Need information for the developer label May 25, 2023
@amoswazana
Copy link
Author

amoswazana commented May 28, 2023

Hi @paulinon
We are seeing this across all Android devices and even on iOS.
Example devices:
Lenovo Tab M10 (HD) (Lenovo TB-X505F), Redmi Note 8T, Galaxy S22 Ultra (SM-S908U), Pixel 6a, and many more.

Example stacktrace from iOS (iPhone 14 pro, iOS 16.4.1):

Crashed: com.apple.main-thread
0  UnityFramework                 0x1904060 firebase::auth::ValidUser(firebase::auth::AuthData const*) + 24
1  UnityFramework                 0x1904038 firebase::auth::User::is_valid() const + 28
2  UnityFramework                 0x1914070 Firebase_Auth_CSharp_FirebaseUser_IsValid + 76
3  UnityFramework                 0x1b7d87c selector_thread(void*) (.cold.1) + 656 (threadpool-ms-io.cpp:656)
4  UnityFramework                 0x1b7f9bc selector_thread(void*) (.cold.1) + 656 (threadpool-ms-io.cpp:656)
5  UnityFramework                 0x1ad2f60 selector_thread(void*) (.cold.1) + 656 (threadpool-ms-io.cpp:656)
6  UnityFramework                 0x1ac3c5c selector_thread(void*) (.cold.1) + 656 (threadpool-ms-io.cpp:656)
7  UnityFramework                 0x1ad0310 selector_thread(void*) (.cold.1) + 656 (threadpool-ms-io.cpp:656)
8  UnityFramework                 0x17956c0 il2cpp::vm::Runtime::InvokeWithThrow(MethodInfo const*, void*, void**) + 578 (Runtime.cpp:578)
9  UnityFramework                 0x1795520 il2cpp::vm::Runtime::Invoke(MethodInfo const*, void*, void**, Il2CppException**) + 572 (Runtime.cpp:572)
10 UnityFramework                 0xdcd204 scripting_method_invoke(ScriptingMethodPtr, ScriptingObjectPtr, ScriptingArguments&, ScriptingExceptionPtr*, bool) + 292 (ScriptingApi_Il2Cpp.cpp:292)
11 UnityFramework                 0xdd8da8 ScriptingInvocation::Invoke(ScriptingExceptionPtr*, bool) + 298 (ScriptingInvocation.cpp:298)
12 UnityFramework                 0xddb350 ScriptingInvocation::InvokeChecked(ScriptingExceptionPtr*) + 72 (ScriptingInvocation.h:72)
13 UnityFramework                 0xe1ea8c SerializableManagedRef::CallMethod(Object&, ScriptingMethodPtr) + 60 (ScriptingNativeTypes.h:60)
14 UnityFramework                 0xe1eaf8 SerializableManagedRef::CallMethod(Object&, char const*) + 621 (SerializableManagedRef.cpp:621)
15 UnityFramework                 0xdd797c ForwardInvokeDelayed(Object*, void*) + 23 (DelayedCallUtility.cpp:23)
16 UnityFramework                 0xc6e0ec DelayedCallManager::Update(int) + 187 (CallDelayed.cpp:187)
17 UnityFramework                 0xd091a0 ExecutePlayerLoop(NativePlayerLoopSystem*) + 383 (PlayerLoop.cpp:383)
18 UnityFramework                 0xd091e0 ExecutePlayerLoop(NativePlayerLoopSystem*) + 407 (PlayerLoop.cpp:407)
19 UnityFramework                 0xd0943c PlayerLoop() + 514 (PlayerLoop.cpp:514)
20 UnityFramework                 0x1210f80 UnityPlayerLoopImpl(bool) + 330 (LibEntryPoint.mm:330)
21 UnityFramework                 0x145d8 -[UnityAppController(Rendering) repaint] + 238 (UnityAppController+Rendering.mm:238)
22 UnityFramework                 0x14568 -[UnityAppController(Rendering) repaintDisplayLink] + 72 (UnityAppController+Rendering.mm:72)
23 QuartzCore                     0x298a4 CA::Display::DisplayLink::dispatch_items(unsigned long long, unsigned long long, unsigned long long) + 820
24 QuartzCore                     0x1471c4 CA::Display::DisplayLink::dispatch_deferred_display_links(unsigned int) + 380
25 UIKitCore                      0x64de00 _UIUpdateSequenceRun + 84
26 UIKitCore                      0xcb1944 schedulerStepScheduledMainSection + 144
27 UIKitCore                      0xcb0ea0 runloopSourceCallback + 92
28 CoreFoundation                 0xd3208 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 28
29 CoreFoundation                 0xdf864 __CFRunLoopDoSource0 + 176
30 CoreFoundation                 0x646c8 __CFRunLoopDoSources0 + 244
31 CoreFoundation                 0x7a1c4 __CFRunLoopRun + 828
32 CoreFoundation                 0x7f4dc CFRunLoopRunSpecific + 612
33 GraphicsServices               0x135c GSEventRunModal + 164
34 UIKitCore                      0x39d37c -[UIApplication _run] + 888
35 UIKitCore                      0x39cfe0 UIApplicationMain + 340
36 UnityFramework                 0x1410c -[UnityFramework runUIApplicationMainWithArgc:argv:] + 96 (main.mm:96)
37 appName                       0x7ccc main + 28 (main.mm:28)
38 ???                            0x1e3e6cdec (Missing)

Also it is important to clarify that the example code I provided in the OP is a simplified version of the login flow on our end. The actual login flow is a bit more complicated and we do not want to post it publicly.

Please let me know if you need any more information.

@a-maurice
Copy link
Collaborator

Hi @amoswazana

Thanks for the issue report, I believe I have identified a potential cause of the crash, and will aim to address it soon.

@a-maurice
Copy link
Collaborator

Alright, the latest release, 11.1.0, https://github.com/firebase/firebase-unity-sdk/releases/tag/v11.1.0, is out now, and should contain the fix for this issue. Thanks again for bringing this to our attention.

@firebase firebase locked and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: auth needs-info Need information for the developer type: question
3 participants