-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FireStore] CRASH : signal 6 JNI ERROR (app bug): global reference table overflow #627
Comments
This looks like a legit bug. Thanks for reporting this and I'll contact the team to dive into this. |
Hi @Thaina, we've figured out what's going on here and are working on a fix. There's a leak of an object in the C#/C++ interface layer and that object is leaking the JNI global references. |
@wilhuff Is it possible for me to know which release version of unitypackage I could expect this fix? |
We'll definitely post here when we release a fix. |
This issue was periodically occur more consistently when I use |
@wilhuff How is this progress? Or I should remove firestore from my app in the meantime? If it was just a leak in persistent storage could we just have option to disable it released as 6.13.1 ? This is a seriously blocking issue on my project manager that they can't test our app without it crashing |
We are making progress on this, but don't have this completely fixed yet. Unfortunately, the leak is not just in persistent storage. The leaks are happening at the interface between C# and C++. The C# side is losing the C++ objects that are managing the JNI handles. |
Thank you for your updating |
@wilhuff There was 6.14 released but it did not mention about any bug fix, or is it still in progress? |
Releases are like trains. If we're ready we can board; if not, we missed it. We missed this one. The good news is that everyone understands the severity of this issue, so we'll likely get an out-of-cycle release just to fix this once we're ready. |
@wilhuff Thank you very much for your clarifying. I understand that there were hardships on your side, but I just want to make sure before update the library |
@wilhuff Sorry for bother you but how is this progressed at all? This is nearly 2 months critical crash bug and there was no workaround at all. Why the fix does not came out yet? |
Still happen in 6.15 updated today
|
Not sure it was the cause but it happen when I keep |
@Thaina again apologies for the delay. We're finalizing the changes that fix this. It won't be long now. On Android, a DocumentSnapshot is ultimately backed by a Java object, so returning them earlier could have some effect. However, our findings are that we were leaking fairly systemically--not just related to DocumentSnapshots--so this can't account for everything. |
Just wanted to add in that we have run into this issue as well and are looking forward to the fix. |
@wilhuff I think 11 days shouldn't be considered as won't be long, should it? |
@wilhuff Now it's remind me that we could never translate time measurement of firebase team in human timescale. We should not expect won't be long to be less than a month. The firestore SDK for unity itself take more than a year for the word soon so won't be long might be 6 months or so? |
Sorry for the delay everyone. We have a fix for this issue internally. We were working on a release on Friday and hit a snag, but I think we've resolved that issue and should have a build we can put out very soon. |
@alexames At first I felt relieved but then again the word very soon of firebase team could be scale in year worth of timescale. And we can't know what you have done at all. There is no transparency in your development process and we have burden with manythings from our side because your bug. Can you please elaborate how soon it will be? |
The release is out now, you can update your SDK and this issue should be resolved. @Thaina Sorry I couldn't give a timeline :( I didn't want to commit to a date that I wasn't absolutely sure we could hit, and any time an issue is found with a release candidate that pushes things back and makes it take longer. |
@alexames We should have this issue still opened. You don't update 6.15.1 to be available in UPM yet |
@wilhuff What happen to the UPM version? Also even in the doc it state that it is 6.15.0 https://firebase.google.com/support/release-notes/unity#6.15.1 The doc seem buggy too |
@chkuang-g Who I need to contact to make UPM available? |
What the hell happen that you take whole week to make sure everything work but not even check how you have been releasing library in UPM. Why everything always broken. Why can't I never trust you guy in anything at all. Why I need to waste my time using firebase, waste my company's money to see bug in my system everytime everywhere and everything You have been wasting your time create firestore unity library for 2 years. Kept everything secret but then making systemically leak that never fixed for 3 months and still systemically fail to release it properly. What the hell is your system? Do you really have a system? I should never trust you for 2 years |
@Thaina I understand your frustration. And the team is continuing working on improving the quality of SDK and the release process. Shawn |
Please fill in the following fields:
Unity editor version: 2018.4.19f
Firebase Unity SDK version: 6.13
Firebase plugins in use : Auth, FireStore, DynamicLinks, Messaging
Additional SDKs you are using : Facebook, GoogleAdsManager, VoxelBusters
Platform you are using the Unity editor on: Windows
Platform you are targeting: Android
Scripting Runtime: IL2CPP
Please answer the following, if applicable:
Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)?
What's the issue repro rate?
Please describe the issue here:
Just have firestore listener for a list of 18-30 of large and complex document. And updating some of them from server has throw these below exception
I am not sure which is the related log, it seem a very large log related was thrown when crash
Firebase.Firestore.QuerySnapshot
JNI ERROR (app bug): global reference table overflow (max=51200)global reference table dump:
(another) JNI ERROR (app bug): global reference table overflow (max=51200)global reference table dump:
Runtime aborting...
CRASH : signal 6 (SIGABRT), code -6 (?), fault addr --------
The text was updated successfully, but these errors were encountered: