Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: update the query destination table legacy file to use query_and_wait API #1775

Merged
merged 10 commits into from
Jan 25, 2024
Merged

Docs: update the query destination table legacy file to use query_and_wait API #1775

merged 10 commits into from
Jan 25, 2024
+3 −2

Conversation

SalemJorden
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jan 12, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Jan 16, 2024
@chalmerlowe chalmerlowe added the type: docs Improvement to the documentation for an API. label Jan 22, 2024
@kiraksi kiraksi self-requested a review January 25, 2024 09:45
kiraksi
kiraksi approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@kiraksi kiraksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM approval
samples/client_query_destination_table_legacy.py Outdated Show resolved Hide resolved
@kiraksi kiraksi marked this pull request as ready for review January 25, 2024 09:48
@kiraksi kiraksi requested review from a team as code owners January 25, 2024 09:48
@kiraksi kiraksi requested a review from parthea January 25, 2024 09:48
@kiraksi kiraksi enabled auto-merge (squash) January 25, 2024 20:58
@kiraksi kiraksi merged commit ef89f9e into googleapis:main Jan 25, 2024
18 of 19 checks passed
@release-please release-please bot mentioned this pull request Jan 25, 2024
Merged
This was referenced Feb 13, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small. type: docs Improvement to the documentation for an API.
3 participants
@SalemJorden @kiraksi @chalmerlowe