Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable - selection: row colour doesn't look nice for frozen columns #3230

Open
sbrauch opened this issue Sep 2, 2022 · 1 comment
Open
Assignees
Labels
Component: Theme Issue or pull request is related to Theme Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@sbrauch
Copy link

sbrauch commented Sep 2, 2022

Describe the bug

I think there might be a bug with the "selection" feature of the data table. It automatically changes the colour of the chosen columns to a transparent background which doesn't look nice with frozen columns. Additionally, it only applies the colour until the point the frozen columns start from the original view. Is this an issue from my side or an actual bug ?

Capture d’écran 2022-09-01 à 16 20 19

Capture d’écran 2022-09-01 à 16 20 23

Reproducer

https://codesandbox.io/s/summer-cloud-zi7eep?file=/src/demo/DataTableScrollDemo.js

PrimeReact version

8.2.0

React version

18.x

Language

ES6

Build / Runtime

Create React App (CRA)

Browser(s)

Brave

Steps to reproduce the behavior

  1. Create a data table with cell edit and enough columns to having to scroll horizontally
  2. Add one or more frozen columns at the right side of the table
  3. Add the selection feature from the data table
  4. Select a row
  5. See the colour of the row being changed to transparent blue up to the frozen columns limit

Expected behavior

Frozen columns colour:

  • Either the frozen columns remain the standard colour and do not get the new transparent colour.
  • Either choose a colour which is not transparent

Frozen colour limit:

  • Colour the entire row in the chosen colour and not only until the frozen line view limit (when scrolling this doesn't look nice)
@sbrauch sbrauch added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 2, 2022
@melloware
Copy link
Member

Thanks for the report!

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 22, 2022
@melloware melloware added the Component: Theme Issue or pull request is related to Theme label Nov 24, 2022
@melloware melloware added this to the 8.7.3 milestone Nov 24, 2022
@mertsincan mertsincan modified the milestones: 8.7.3, 8.7.4 Dec 5, 2022
@mertsincan mertsincan modified the milestones: 8.7.4, 10.0.0 Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Theme Issue or pull request is related to Theme Type: Bug Issue contains a defect related to a specific component.
3 participants