[Library Update] Upgrade Firebase to 10.24.0 #1668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades Firebase to 10.24.0.
In this version, they added XCFramework signing, although I'm not sure if it's actually needed since we've been passing App Store validation.
To test
There are two main things we need to test: events and remote feature flags. The app also uses Performance but we're looking into removing that so it's not part of the testing steps.
Remote Feature Flags
Constants.swift
and changenewPlayerTransitionDefault
tofalse
newPlayerTransition
should be enabled, which means remote feature flags are working as expectedEvents
AnalyticsHelper.swift
and changeprivate extension AnalyticsHelper
toextension AnalyticsHelper
ProfileViewController.swift
addAnalyticsHelper.logEvent("testing_testing")
on the end ofviewDidAppear
Checklist
CHANGELOG.md
if necessary.