-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove unit-test that RULES.md is up-to-date with Notice classes. #1517
Conversation
Should we, as part of this PR, rewrite RULES.MD pointing to the web-validator documentation(https://gtfs-validator.mobilitydata.org/rules.html) and removing all the rules information? It can be done as a quick follow-up too. |
✅ Rule acceptance tests passed. |
@davidgamez I've updated |
✅ Rule acceptance tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Per #1515, we have moved away from
RULES.md
as the canonical source of notice documentation. As part of this deprecation, this PR removes the unit-test that checks thatRULES.md
has an entry for every notice class.Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything