-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added a execution result file #1690
fix: Added a execution result file #1690
Conversation
✅ Rule acceptance tests passed. |
…web-validator-jobs
...rc/main/java/org/mobilitydata/gtfsvalidator/web/service/controller/ValidationController.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/mobilitydata/gtfsvalidator/web/service/controller/ValidationController.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/mobilitydata/gtfsvalidator/web/service/controller/ValidationController.java
Outdated
Show resolved
Hide resolved
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…web-validator-jobs
✅ Rule acceptance tests passed. |
…web-validator-jobs
✅ Rule acceptance tests passed. |
Summary:
closes #1688
Added
execution_result.json
file containing the result of the execution of the validation.This file should be available at the same location as the report files (report.html, report.json, etc)
Typical contents of this file:
or
Now the endpoint always return 200.
Testing tips
.github/workflows/stg_web_svc_merge.yml
but this will not be available until this branch is merged into master.report.html
at the end of the report URL byexecution_result.json
. You should be able to load the filePlease make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything