Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: used the standard date time formatter #1691

Conversation

qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Mar 6, 2024

Summary:
Closes #1652
image
report.json

Expected behavior:

Please see the validatedAt string on the screenshot and json report.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)
@qcdyx qcdyx requested a review from jcpitre March 6, 2024 21:18
@davidgamez
Copy link
Member

Can we remove the milliseconds and the name of the timezone? Example: 2024-01-15T24:14:45+05:00

@qcdyx
Copy link
Contributor Author

qcdyx commented Mar 6, 2024

Copy link
Contributor

github-actions bot commented Mar 6, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1520 sources (~0 %) are corrupted.
Commit: d8d6966
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@qcdyx
Copy link
Contributor Author

qcdyx commented Mar 7, 2024

Regarding when --date is passed in the validator question @davidgamez, I tried java -Xmx1G -jar ./cli/build/libs/gtfs-validator-4.2.1-SNAPSHOT-cli.jar -d 2023-01-01 -o /Users/jingsi/code/data/gtfs-ws/delfi -i /Users/jingsi/Downloads/google-transit-darwin-200124.zip and it's working.
image

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

github-actions bot commented Mar 7, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1520 sources (~0 %) are corrupted.
Commit: 94243f8
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@qcdyx qcdyx merged commit 4df6de3 into master Mar 7, 2024
333 checks passed
@qcdyx qcdyx deleted the 1652-make-the-datetime-in-the-json-report-for-validatedat-a-standard-format branch March 7, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants