Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export notice schema as json file #925

Merged
merged 50 commits into from
Aug 16, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
9f6b822
feat: --dump_notices_schema or -d
Jun 22, 2021
932a795
Merge remote-tracking branch 'origin/master' into feat/dump-json-schema
Jul 9, 2021
3c76b9a
rename CLI parameter
Jul 9, 2021
1036c0b
make NoticeExport annotation visible at runtime
Jul 9, 2021
03b9424
pick the right constructor for schema export in CsvParsingFailedNotice
Jul 9, 2021
e0834e7
Make parameters's name discoverable a runtime + clean up of gradle.bu…
Jul 9, 2021
e7ad1b3
implement logic for notice schema export
Jul 9, 2021
8870e71
unit tests
Jul 9, 2021
d21f9b5
create json file
Jul 9, 2021
30ed17e
export if -n is provided
Jul 9, 2021
390aa20
typo
Jul 9, 2021
0b44560
Merge remote-tracking branch 'origin/master' into feat/dump-json-schema
Jul 15, 2021
2557254
apply suggestions from code review
Jul 21, 2021
898f284
provide suggestions from code review
Jul 21, 2021
09e11bd
use SchemaExport annotation
Jul 21, 2021
1cf0106
add copyright header
Jul 21, 2021
3298fc3
revert changes to javadocs
Jul 23, 2021
4a128d8
move variables to annotation definition
Jul 23, 2021
d6f549b
enable schema generation without providing other parameters
Jul 23, 2021
ff781dd
simplify checks from extractCoreNoticesProperties
Jul 23, 2021
12acd6f
refactor: rename method for clarity
Jul 23, 2021
1eab42b
programmatically retrieve package name from classes
Jul 23, 2021
7347206
docs: update to match the latest dev
Jul 23, 2021
96d6278
Merge branch 'master' into feat/dump-json-schema
Jul 28, 2021
7d3da1c
introduce new argument: --abort_after_schema_extraction
Jul 28, 2021
b9000a3
rework package name retrieval process
Jul 28, 2021
5163bd9
remove usused import statements
Jul 28, 2021
6e97a97
rework default value logic for --abort_after_schema_extraction CLI pa…
Jul 28, 2021
8af89f2
rework notice construction
Jul 28, 2021
bc04ce4
docs: update to match latest dev
Jul 28, 2021
7941d71
docs: update to match latest dev
Jul 28, 2021
72730b7
apply suggestion from code review
lionel-nj Jul 28, 2021
a46270f
apply suggestions from code review
Jul 30, 2021
f7be4cd
apply suggestions from code review:
Aug 3, 2021
790597b
fix tests
Aug 3, 2021
7cae579
remove code for debugging in test
Aug 3, 2021
ef77a4f
define custom exception ConstructorParametersInconsistencyException
Aug 3, 2021
8b08e4d
remove package com.sun.jdi.InvalidTypeException form tests
Aug 3, 2021
5043dbc
apply google-java-style plugin
Aug 3, 2021
3331ead
sort keys from json schema alphabetically
Aug 3, 2021
3f591e2
remove CLI parameter abort_after_schema_extraction
Aug 4, 2021
5863170
Merge branch 'master' into feat/dump-json-schema
Aug 10, 2021
e882db5
remove support for annotations
Aug 10, 2021
25bf9a6
Merge branch 'master' into feat/dump-json-schema
Aug 12, 2021
58f8a93
plug contribution from #951 into Main.java
Aug 12, 2021
1c4db69
remove unused classes
Aug 12, 2021
0d699e7
style: apply google-java-format plugin
Aug 12, 2021
7d6b8be
touch
Aug 12, 2021
6c02c30
Merge branch 'master' into feat/dump-json-schema
Aug 16, 2021
d31b637
style: format code
Aug 16, 2021
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make parameters's name discoverable a runtime + clean up of gradle.bu…
…ild files (remove jackson dependencies)
  • Loading branch information
lionel-nj committed Jul 9, 2021
commit e0834e7a72ce65a88229dadd8925e05e1610ac3c
8 changes: 8 additions & 0 deletions core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,11 @@ test {
events "passed", "skipped", "failed"
}
}

compileJava {
options.compilerArgs << '-parameters'
}

compileTestJava {
options.compilerArgs << '-parameters'
}
6 changes: 3 additions & 3 deletions main/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ jar {
shadowJar {
minimize {
exclude(dependency('org.apache.logging.log4j:log4j-core'))
exclude(dependency('com.fasterxml.jackson.core:jackson-databind'))
exclude(dependency('org.apache.httpcomponents:httpclient'))
}
// Change the JAR name from cli-app to gtfs-validator
Expand All @@ -66,7 +65,6 @@ dependencies {
implementation 'org.apache.httpcomponents.client5:httpclient5:5.0.3'
implementation 'com.beust:jcommander:1.48'
implementation 'javax.inject:javax.inject:1'
implementation 'com.fasterxml.jackson.core:jackson-databind:2.10.0'
implementation 'com.google.guava:guava:29.0-jre'
implementation 'com.google.flogger:flogger:0.5.1'
implementation 'com.google.flogger:flogger-system-backend:0.5.1'
Expand All @@ -75,7 +73,6 @@ dependencies {
implementation 'org.locationtech.spatial4j:spatial4j:0.7'
testImplementation group: 'junit', name: 'junit', version: '4.13'
testImplementation "com.google.truth:truth:1.0.1"
testImplementation 'com.fasterxml.jackson.core:jackson-databind:2.10.0'
lionel-nj marked this conversation as resolved.
Show resolved Hide resolved
}

test {
Expand All @@ -88,3 +85,6 @@ test {
}
}

compileJava {
options.compilerArgs << '-parameters'
}