[PcGamerBridge] fix pc gamer, revert to meta tags, get image from meta tag as enclosure, get category tags #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…decode description
|
Hi, @mdemoss ! |
I'm not sure why they have some of those tags, maybe it's for their internal use. I filtered out a couple already at rss-bridge/bridges/PcGamerBridge.php Line 28 in a60c6ef Maybe a better approach could be to remove every tag that contains an underscore, at the risk of losing some meaningful tags. |
floviolleau
pushed a commit
to floviolleau/rss-bridge
that referenced
this pull request
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect using meta tags and
a.article-linkshould be less likely to break in the future.If
a.article-linkshould break, then finding eachafor the same domain and checking for the meta tags whereog:typeisarticleought to be even more durable.