feat: extract curl ua to config value #2568
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows for modification of the curl ua in config.ini.php.
It's mostly a refactor but leaving out the version and github url from the ua. Ideally the ua should contain some information on how to reach the person responsible for the network traffic. But that only's a problem with misbehaving clients who spam with http requests. Could encourage bridge instances to modify it to include some contact information.
That ua is one of the most popular uas. It's Chrome 74 on Windows 10:
https://developers.whatismybrowser.com/useragents/parse/1302411chrome-windows-blink