Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jetchat] Update to Material 3 #690

Merged
merged 9 commits into from
Oct 27, 2021
Merged

[Jetchat] Update to Material 3 #690

merged 9 commits into from
Oct 27, 2021

Conversation

ricknout
Copy link
Contributor

@ricknout ricknout commented Oct 25, 2021 •
edited
Loading

  • Use androidx.compose.material3
  • Material 3 theming and components
  • Material You dynamic color
  • Other minor design updates
nickbutcher
nickbutcher reviewed Oct 26, 2021
View reviewed changes
Copy link
Contributor

@nickbutcher nickbutcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it intentional to update other samples to compose 1.1.0 snapshots and respective Accompanist version?
@ricknout
Copy link
Contributor Author

@nickbutcher this branch was branched from #684, and the dependencies (for Jetchat at least) are required here
@JolandaVerhoef
Copy link
Contributor

There's a bug with overscroll when you open the app and try to scroll. Tried on Android 12 emulator. This bug isn't present in the main branch.
@ricknout
Copy link
Contributor Author

@JolandaVerhoef hmm this could perhaps be a bug in Compose Foundation 1.1.0-beta01, which is where the new stretch overscroll is happening. Any chance you can try and replicate on this branch: #684 ?
@JolandaVerhoef
Copy link
Contributor

Yes, that branch has the same issue.
@JolandaVerhoef
Copy link
Contributor

Ok this was due to my emulator.
@ricknout ricknout closed this Oct 27, 2021
@ricknout ricknout reopened this Oct 27, 2021
@ricknout ricknout merged commit 686b550 into android:main Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
4 participants
@ricknout @JolandaVerhoef @nickbutcher @googlebot